From 6de977b538d1a9dbf2f0b257b845254225673689 Mon Sep 17 00:00:00 2001 From: chad Date: Fri, 1 Sep 2023 10:33:59 -0700 Subject: [PATCH 1/5] fix(mdns): require loopback addresses to be ignored --- discovery/mdns.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/discovery/mdns.md b/discovery/mdns.md index d6eee4a7c..02089c533 100644 --- a/discovery/mdns.md +++ b/discovery/mdns.md @@ -120,7 +120,7 @@ Many existing tools ignore the Additional Records, and always send individual qu ## Issues -[ ] mDNS requires link-local addresses. Loopback and "NAT busting" addresses should not sent and must be ignored on receipt? +mDNS requires link-local addresses. Loopback and "NAT busting" addresses should not sent and must be ignored on receipt. ## References From 1e3aa9cda65e7d4eac56b8a553a79de747f4ff9b Mon Sep 17 00:00:00 2001 From: chad Date: Fri, 1 Sep 2023 10:33:59 -0700 Subject: [PATCH 2/5] fix(mdns): require loopback addresses to be ignored --- discovery/mdns.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/discovery/mdns.md b/discovery/mdns.md index 02089c533..7ed9b0be3 100644 --- a/discovery/mdns.md +++ b/discovery/mdns.md @@ -2,9 +2,9 @@ > Local peer discovery with zero configuration using multicast DNS. -| Lifecycle Stage | Maturity | Status | Latest Revision | -|-----------------|----------------|--------|-----------------| -| 1A | Working Draft | Active | r2, 2021-10-12 | +| Lifecycle Stage | Maturity | Status | Latest Revision | +| --------------- | ------------- | ------ | --------------- | +| 1A | Working Draft | Active | r2, 2021-10-12 | Authors: [@richardschneider] @@ -120,7 +120,7 @@ Many existing tools ignore the Additional Records, and always send individual qu ## Issues -mDNS requires link-local addresses. Loopback and "NAT busting" addresses should not sent and must be ignored on receipt. +mDNS requires link-local addresses. Loopback and "NAT busting" addresses should be not sent and must be ignored on receipt. ## References From c55d3fa572b813faefe5cd01256db0b4c7cd7b27 Mon Sep 17 00:00:00 2001 From: chad Date: Fri, 1 Sep 2023 10:41:45 -0700 Subject: [PATCH 3/5] chore: update grammar + formatting --- discovery/mdns.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/discovery/mdns.md b/discovery/mdns.md index 7ed9b0be3..de4d6d924 100644 --- a/discovery/mdns.md +++ b/discovery/mdns.md @@ -2,9 +2,9 @@ > Local peer discovery with zero configuration using multicast DNS. -| Lifecycle Stage | Maturity | Status | Latest Revision | -| --------------- | ------------- | ------ | --------------- | -| 1A | Working Draft | Active | r2, 2021-10-12 | +| Lifecycle Stage | Maturity | Status | Latest Revision | +|-----------------|----------------|--------|-----------------| +| 1A | Working Draft | Active | r2, 2021-10-12 | Authors: [@richardschneider] @@ -120,7 +120,7 @@ Many existing tools ignore the Additional Records, and always send individual qu ## Issues -mDNS requires link-local addresses. Loopback and "NAT busting" addresses should be not sent and must be ignored on receipt. +mDNS requires link-local addresses. Loopback and "NAT busting" addresses should not be sent and must be ignored on receipt. ## References From 203bacc8cee5d2b6b079b479af7599b7522d86a1 Mon Sep 17 00:00:00 2001 From: chad Date: Mon, 4 Sep 2023 12:04:03 -0500 Subject: [PATCH 4/5] chore: remove the issues section and place recommendation in responses --- discovery/mdns.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/discovery/mdns.md b/discovery/mdns.md index de4d6d924..2507e8857 100644 --- a/discovery/mdns.md +++ b/discovery/mdns.md @@ -85,6 +85,8 @@ The **additional records** of the response contain the peer's discovery details: The TXT record contains the multiaddresses that the peer is listening on. Each multiaddress is a TXT attribute with the form `dnsaddr=/.../p2p/QmId`. Multiple `dnsaddr` attributes and/or TXT records are allowed. +Note that `mDNS` requires link-local addresses. Loopback and "NAT busting" addresses should not be sent and must be ignored on receipt. + ## DNS Service Discovery DNS-SD support is not needed for peers to discover each other. However, it is extremely useful for network administrators to discover what is running on the network. @@ -118,9 +120,6 @@ Many existing tools ignore the Additional Records, and always send individual qu - ` A` - ` AAAA` -## Issues - -mDNS requires link-local addresses. Loopback and "NAT busting" addresses should not be sent and must be ignored on receipt. ## References From 6e7883d741b4d07056a66fd134c37a3581b9c498 Mon Sep 17 00:00:00 2001 From: chad Date: Fri, 22 Sep 2023 12:56:01 -0500 Subject: [PATCH 5/5] mdns: remove issue regarding loopback addresses --- discovery/mdns.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/discovery/mdns.md b/discovery/mdns.md index 2507e8857..4f7916b8b 100644 --- a/discovery/mdns.md +++ b/discovery/mdns.md @@ -85,8 +85,6 @@ The **additional records** of the response contain the peer's discovery details: The TXT record contains the multiaddresses that the peer is listening on. Each multiaddress is a TXT attribute with the form `dnsaddr=/.../p2p/QmId`. Multiple `dnsaddr` attributes and/or TXT records are allowed. -Note that `mDNS` requires link-local addresses. Loopback and "NAT busting" addresses should not be sent and must be ignored on receipt. - ## DNS Service Discovery DNS-SD support is not needed for peers to discover each other. However, it is extremely useful for network administrators to discover what is running on the network. @@ -120,7 +118,6 @@ Many existing tools ignore the Additional Records, and always send individual qu - ` A` - ` AAAA` - ## References - [RFC 1035 - Domain Names (DNS)](https://tools.ietf.org/html/rfc1035)