Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fail if older version installed #111

Open
dmacks opened this issue Dec 28, 2020 · 1 comment
Open

Compile fail if older version installed #111

dmacks opened this issue Dec 28, 2020 · 1 comment

Comments

@dmacks
Copy link

dmacks commented Dec 28, 2020

Equivalent cause as libimobiledevice/libplist#185, but now it's a plain compile fail. I have libusbmuxd v1 installed, so building the new version fails beginning with:

gcc -DHAVE_CONFIG_H -I. -I..   -I/sw/include -Wall -Wextra -Wmissing-declarations -Wredundant-decls -Wshadow -Wpointer-arith -Wwrite-strings -Wswitch-default -Wno-unused-parameter -fvisibility=hidden -pthread -I../common -I../src -I../include -g -O2 -MT inetcat-inetcat.o -MD -MP -MF .deps/inetcat-inetcat.Tpo -c -o inetcat-inetcat.o `test -f 'inetcat.c' || echo './'`inetcat.c
inetcat.c:116:39: error: variable has incomplete type 'enum usbmux_lookup_options'
    static enum usbmux_lookup_options lookup_opts = 0;
                                      ^

because global -I/sw/include masks source-dist -I../common

@dmacks
Copy link
Author

dmacks commented Dec 28, 2020

Fix here is simple. In tools/Makefile.am, change:

AM_CFLAGS = $(GLOBAL_CFLAGS) -I$(top_srcdir)/common -I$(top_srcdir)/src -I$(top_srcdir)/include

to:

AM_CPPFLAGS = -I$(top_srcdir)/common -I$(top_srcdir)/src -I$(top_srcdir)/include $(GLOBAL_CFLAGS)

as a side benefit, that allows you to scrap iproxy_CFLAGS and iproxy_CFLAGS altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant