Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy Linter Errors on Rust version 1.67 #335

Closed
mimullin-bbry opened this issue Jan 26, 2023 · 2 comments
Closed

Clippy Linter Errors on Rust version 1.67 #335

mimullin-bbry opened this issue Jan 26, 2023 · 2 comments
Assignees

Comments

@mimullin-bbry
Copy link
Contributor

Clippy on rust version 1.67 throws warnings for uninlined_format_args

eg.

warning: `capable` (bin "capable") generated 1 warning
warning: variables can be used directly in the `format!` string
  --> examples/runqslower/src/main.rs:74:5
   |
74 |     eprintln!("Lost {} events on CPU {}", count, cpu);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
   = note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
   |
74 -     eprintln!("Lost {} events on CPU {}", count, cpu);
74 +     eprintln!("Lost {count} events on CPU {cpu}");

A simple "cargo clippy --fix" can probably address the necessary changes, but I wont be able to tackle this until the weekend.

@danielocfb danielocfb self-assigned this Jan 26, 2023
@danielocfb
Copy link
Collaborator

I already started looking at that; will take care of it. Thanks for the report.

@danielocfb
Copy link
Collaborator

Closed by #336.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants