Skip to content

Commit 123ed59

Browse files
authored
Minor: update git-blmae-ignore-revs, and uncomment ClassificationResourceTest tests code (open-metadata#14431)
1 parent 451a20b commit 123ed59

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

.git-blame-ignore-revs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8c2a1e415dbe00b89e7105905f0e1e7e6296a5c4
1+
1294f93e15258c4d0ea2f8d4f0b746a6267dd6cc

.pre-commit-config.yaml.swp

-12 KB
Binary file not shown.

openmetadata-service/src/test/java/org/openmetadata/service/resources/tags/ClassificationResourceTest.java

+7-5
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import org.openmetadata.schema.entity.classification.Classification;
4141
import org.openmetadata.schema.entity.classification.Tag;
4242
import org.openmetadata.schema.type.ChangeDescription;
43+
import org.openmetadata.schema.type.ProviderType;
4344
import org.openmetadata.service.Entity;
4445
import org.openmetadata.service.exception.CatalogExceptionMessage;
4546
import org.openmetadata.service.resources.EntityResourceTest;
@@ -98,17 +99,18 @@ public CreateClassification createRequest(String name) {
9899
@Override
99100
public void validateCreatedEntity(
100101
Classification createdEntity, CreateClassification request, Map<String, String> authHeaders) {
101-
// assertEquals(
102-
// request.getProvider() == null ? ProviderType.USER : request.getProvider(),
103-
// createdEntity.getProvider());
102+
assertEquals(
103+
request.getProvider() == null ? ProviderType.USER : request.getProvider(),
104+
createdEntity.getProvider());
104105
assertEquals(request.getMutuallyExclusive(), createdEntity.getMutuallyExclusive());
105106
}
106107

107108
@Override
108109
public void compareEntities(
109110
Classification expected, Classification updated, Map<String, String> authHeaders) {
110-
// assertEquals(expected.getProvider() == null ? ProviderType.USER : expected.getProvider(),
111-
// updated.getProvider());
111+
assertEquals(
112+
expected.getProvider() == null ? ProviderType.USER : expected.getProvider(),
113+
updated.getProvider());
112114
assertEquals(expected.getMutuallyExclusive(), updated.getMutuallyExclusive());
113115
}
114116

0 commit comments

Comments
 (0)