Address a few 'cargo clippy' warnings

Author: michaelklishin

src/blocking.rs

@@ -1,7 +1,7 @@
 use crate::{
     requests::{
         ExchangeParams, QueueParams, RuntimeParameterDefinition, UserParams, VirtualHostParams,
-        XArguments
+        XArguments,
     },
     responses,
 };
@@ -24,9 +24,9 @@ impl<'a> Client<'a> {
         password: Option<&'a str>,
     ) -> Self {
         Self {
-            endpoint: endpoint,
-            username: username,
-            password: password,
+            endpoint,
+            username,
+            password,
         }
     }
 
@@ -90,9 +90,8 @@ impl<'a> Client<'a> {
     pub fn list_bindings_in(
         &self,
         virtual_host: &str,
-        ) -> responses::Result<Vec<responses::BindingInfo>> {
-        let response =
-            self.http_get(&format!("bindings/{}", self.percent_encode(virtual_host)))?;
+    ) -> responses::Result<Vec<responses::BindingInfo>> {
+        let response = self.http_get(&format!("bindings/{}", self.percent_encode(virtual_host)))?;
         response.json::<Vec<responses::BindingInfo>>()
     }
 
@@ -126,8 +125,8 @@ impl<'a> Client<'a> {
     ) -> responses::Result<responses::QueueInfo> {
         let response = self.http_get(&format!(
             "queues/{}/{}",
-            self.percent_encode(&virtual_host),
-            self.percent_encode(&name)
+            self.percent_encode(virtual_host),
+            self.percent_encode(name)
         ))?;
         let queue = response.json::<responses::QueueInfo>()?;
         Ok(queue)
@@ -140,8 +139,8 @@ impl<'a> Client<'a> {
     ) -> responses::Result<responses::ExchangeInfo> {
         let response = self.http_get(&format!(
             "exchanges/{}/{}",
-            self.percent_encode(&virtual_host),
-            self.percent_encode(&name)
+            self.percent_encode(virtual_host),
+            self.percent_encode(name)
         ))?;
         let exchange = response.json::<responses::ExchangeInfo>()?;
         Ok(exchange)
@@ -153,15 +152,15 @@ impl<'a> Client<'a> {
 
     pub fn update_vhost(&self, params: &VirtualHostParams) -> responses::Result<()> {
         let _ = self.http_put(
-            &format!("vhosts/{}", self.percent_encode(&params.name)),
+            &format!("vhosts/{}", self.percent_encode(params.name)),
             params,
         )?;
         Ok(())
     }
 
     pub fn create_user(&self, params: &UserParams) -> responses::Result<()> {
         let _ = self.http_put(
-            &format!("users/{}", self.percent_encode(&params.name)),
+            &format!("users/{}", self.percent_encode(params.name)),
             params,
         )?;
         Ok(())
@@ -171,8 +170,8 @@ impl<'a> Client<'a> {
         let _ = self.http_put(
             &format!(
                 "queues/{}/{}",
-                self.percent_encode(&virtual_host),
-                self.percent_encode(&params.name)
+                self.percent_encode(virtual_host),
+                self.percent_encode(params.name)
             ),
             params,
         )?;
@@ -187,8 +186,8 @@ impl<'a> Client<'a> {
         let _ = self.http_put(
             &format!(
                 "exchanges/{}/{}",
-                self.percent_encode(&virtual_host),
-                self.percent_encode(&params.name)
+                self.percent_encode(virtual_host),
+                self.percent_encode(params.name)
             ),
             params,
         )?;
@@ -324,9 +323,9 @@ impl<'a> Client<'a> {
     ) -> responses::Result<()> {
         let path = format!(
             "parameters/{}/{}/{}",
-            self.percent_encode(&component),
-            self.percent_encode(&vhost),
-            self.percent_encode(&name)
+            self.percent_encode(component),
+            self.percent_encode(vhost),
+            self.percent_encode(name)
         );
         self.http_delete(&path)?;
         Ok(())

src/password_hashing.rs

@@ -18,9 +18,7 @@ pub fn salted_password_hash_sha256(salt: &Vec<u8>, password: &str) -> Vec<u8> {
     let digest = ctx.finish();
     let digest_vec = Vec::from(digest.as_ref());
 
-    let res = Vec::from([&salt[..], &digest_vec[..]].concat());
-
-    res
+    [&salt[..], &digest_vec[..]].concat()
 }
 
 pub fn base64_encoded_salted_password_hash_sha256(salt: &Vec<u8>, password: &str) -> String {

src/requests.rs

@@ -39,7 +39,7 @@ impl<'a> QueueParams<'a> {
     pub fn new_quorum_queue(name: &'a str, optional_args: XArguments) -> Self {
         let args = Self::combined_args(optional_args, QueueType::Quorum);
         Self {
-            name: name,
+            name,
             queue_type: QueueType::Quorum,
             durable: true,
             auto_delete: false,
@@ -51,7 +51,7 @@ impl<'a> QueueParams<'a> {
     pub fn new_stream(name: &'a str, optional_args: XArguments) -> Self {
         let args = Self::combined_args(optional_args, QueueType::Stream);
         Self {
-            name: name,
+            name,
             queue_type: QueueType::Stream,
             durable: true,
             auto_delete: false,
@@ -63,7 +63,7 @@ impl<'a> QueueParams<'a> {
     pub fn new_durable_classic_queue(name: &'a str, optional_args: XArguments) -> Self {
         let args = Self::combined_args(optional_args, QueueType::Classic);
         Self {
-            name: name,
+            name,
             queue_type: QueueType::Classic,
             durable: true,
             auto_delete: false,
@@ -75,7 +75,7 @@ impl<'a> QueueParams<'a> {
     pub fn new_exclusive_classic_queue(name: &'a str, optional_args: XArguments) -> Self {
         let args = Self::combined_args(optional_args, QueueType::Classic);
         Self {
-            name: name,
+            name,
             queue_type: QueueType::Classic,
             durable: false,
             auto_delete: false,
@@ -88,9 +88,8 @@ impl<'a> QueueParams<'a> {
         let mut result = Map::<String, Value>::new();
         result.insert("x-queue-type".to_owned(), Value::String(queue_type.into()));
 
-        match optional_args {
-            Some(mut val) => result.append(&mut val),
-            None => (),
+        if let Some(mut val) = optional_args {
+            result.append(&mut val)
         }
 
         Some(result)

tests/binding_tests.rs

@@ -14,19 +14,25 @@ fn test_list_bindings() {
 
     let result1 = rc.declare_queue(vh_name, &QueueParams::new_durable_classic_queue(cq, None));
     assert!(result1.is_ok());
-    
+
     let result2 = rc.bind_queue(vh_name, cq, fanout, None, None);
     assert!(result2.is_ok());
 
     let result3 = rc.list_bindings();
     assert!(result3.is_ok());
     let vec = result3.unwrap();
-    assert!(vec.iter().find(|vh| vh.destination == cq && vh.source == fanout).is_some());
-    
+    assert!(vec
+        .iter()
+        .find(|vh| vh.destination == cq && vh.source == fanout)
+        .is_some());
+
     let result4 = rc.list_bindings_in(vh_name);
     assert!(result4.is_ok());
     let vec = result4.unwrap();
-    assert!(vec.iter().find(|vh| vh.vhost == vh_name && vh.source == fanout).is_some());    
-    
+    assert!(vec
+        .iter()
+        .find(|vh| vh.vhost == vh_name && vh.source == fanout)
+        .is_some());
+
     let _ = rc.delete_queue(vh_name, cq);
 }