The default sorting order of the Models page is rather obscure

[lehors]

It is currently unclear why some models appear before others when the page is sorted by classification (which is the default).

For example, why isn't XGen before OLMO?

Why aren't the models with some progress toward the next Class before those that don't?

[gregcube]

When a model is saved, an evaluation is run, and the total progress is captured along side the model details. The total_progress table column is used to sort the model list.

OLMO-7B is 50% complete; XGen is 44.7619% complete.

mT5-XXL = 13.8095%
PAGnol = 11.2698%
Hawk = 11.2698%
Phi-1 = 11.2698%

However, mT5-XXL has invalid licenses specified for some class 3 components; same goes for Hawk. So in this case no class specific progress badge is generated or displayed in the model list. Seems the badging code was updated to skip invalid ('Not met') badges if $mini is true.

PAGnol and Phi-1 have valid licenses for class 3 components, so the badge is displayed on the model list page.

The badge only shows class specific progress, not total progress.

[lehors]

Thanks for the additional info. I did change the badging code to only display badges that have been earned or in progress. That's not the issue though.
If a model has an invalid license I would expect its total_progress to be lower than one with valid licenses so I don't understand why mT5-XXL has a greater number than PAGnol, and Hawk a greater number than Phi-1.

[gregcube]

Just digging into this more... Comparing mT5-XXL and PAGnol...

Total progress for mT5-XXL is 13.8095%
Total progress for PAGnol is 11.2698%

mT5-XXL Class 3 progress: 0%
mT5-XXL Class 2 progress: 20%
mT5-XXL Class 1 progress: 21%

PAGnol Class 3 progress: 17%
PAGnol Class 2 progress: 10%
PAGnol Class 1 progress: 7%

mT5-XXL is closer to 100% completion as a whole; however, I think the confusion lies within the badging code. If a model has any invalid components for whatever class, the badge is generated with Not met text instead of a progress percentage, which visually throws things off.

On your local instance, try this out --

Comment out the following code block:

model_openness_tool/web/modules/mof/src/ModelEvaluator.php

Lines 165 to 173 in d7f3f97

	else if (!empty($evals[$i]['invalid'])) {
	$status = $this->t('Not met');
	$text_color = '#fff';
	$background_color = '#9ba0a2';
	if ($mini) {
	// do not include classes that are not met
	continue;
	}
	}

Then visit the model page for mT5-XXL and PAGnol. You'll see progress for mT5-XXL instead of the Not met badge. Just because there are invalid licenses for a component doesn't mean progress is zero.

Furthermore, if you change this line:

model_openness_tool/web/modules/mof/src/ModelListBuilder.php

Line 166 in d7f3f97

'data' => $this->modelEvaluator->setModel($entity)->generateBadge(mini: TRUE),

to:

'data' => $this->modelEvaluator->setModel($entity)->generateBadge(),

The model list page will make more sense. I think.

I hope this clears things up. Perhaps we need to re-factor the progression or badging code so it's visually clear to the end user what is what.