Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reaction_idx field to the tracerecord #389

Open
erlingrj opened this issue Mar 7, 2024 · 1 comment
Open

Add a reaction_idx field to the tracerecord #389

erlingrj opened this issue Mar 7, 2024 · 1 comment

Comments

@erlingrj
Copy link
Collaborator

erlingrj commented Mar 7, 2024

Currently, for tracepoints such as reaction_starts and reaction_ends, the reaction index is passed to the dst_id field of the tracerecord. This is a little inconsistent and the better approach would be to add a new field to the trace record called reaction_idx.

This would likely also need changes in the various trace_to_X utilities and fedsd and other external trace plugins.

@edwardalee
Copy link
Contributor

One goal in this design is to fit as many trace points as possible into an in-memory buffer. I suggest instead changing the name of the field rather than increasing the footprint of each record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants