Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataStorage] Upgrade to EdgeX v2.1 (Jakarta) #431

Open
tiokim opened this issue Dec 3, 2021 · 5 comments
Open

[DataStorage] Upgrade to EdgeX v2.1 (Jakarta) #431

tiokim opened this issue Dec 3, 2021 · 5 comments
Assignees
Labels
help wanted Extra attention is needed refactoring Any tasks and issues w.r.t. the code refactoring

Comments

@tiokim
Copy link
Contributor

tiokim commented Dec 3, 2021

EdgeX v2.1 has been released.
We should think of adopting this or not.

@tiokim tiokim added help wanted Extra attention is needed refactoring Any tasks and issues w.r.t. the code refactoring labels Dec 3, 2021
@MoonkiHong
Copy link
Contributor

@lf-edge/edge-home-orchestration-go-maintainers We are currently relying on EdgeX for DataStorage and CloudSync. for MQTT. Need a review from @suresh-lc, @NiranjanPatil25 and @nitu-s-gupta firstly for any API backward compatibility issue. Please feel free to share your investigation. 🙏

@tiokim tiokim changed the title [DataStorage] Upgrade to EdgeX v2.1 (Jarkarta) [DataStorage] Upgrade to EdgeX v2.1 (Jakarta) Dec 3, 2021
@suresh-lc
Copy link
Contributor

@lf-edge/edge-home-orchestration-go-maintainers We are currently relying on EdgeX for DataStorage and CloudSync. for MQTT. Need a review from @suresh-lc, @NiranjanPatil25 and @nitu-s-gupta firstly for any API backward compatibility issue. Please feel free to share your investigation. 🙏

Will check on the latest release of EdgeX v2.1 and let know. For CloudSync anyways we are trying to have independent module.

@nitu-s-gupta
Copy link
Contributor

Initial analysis shows there has been some folder structure changes predominantly in go-mod-contracts which is used for the api with the names of keys being changed. Hence would suggest for following options

  1. go for the similar folder structure of maintaining v1 and v2 to maintain backward compatibility
  2. Since our previous release already support previous versions of edgex, we can make this compatible starting from jakarta. If anybdy wants to use the previous edgex can go for previous releases of ours. Since keeping both would require downloading sdks and other dependencies in vendor directory there by increasing the size of the project

Suggestion of any options above mentioned or else otherwise is welcome!!

@MoonkiHong
Copy link
Contributor

Initial analysis shows there has been some folder structure changes predominantly in go-mod-contracts which is used for the api with the names of keys being changed. Hence would suggest for following options

  1. go for the similar folder structure of maintaining v1 and v2 to maintain backward compatibility
  2. Since our previous release already support previous versions of edgex, we can make this compatible starting from jakarta. If anybdy wants to use the previous edgex can go for previous releases of ours. Since keeping both would require downloading sdks and other dependencies in vendor directory there by increasing the size of the project

Suggestion of any options above mentioned or else otherwise is welcome!!

What if we take a policy to separate the repo for edge-home-orchestration-go and DataStorage as we discuss in other thread w.r.t. #415?

@tiokim
Copy link
Contributor Author

tiokim commented Jan 3, 2022

Initial analysis shows there has been some folder structure changes predominantly in go-mod-contracts which is used for the api with the names of keys being changed. Hence would suggest for following options

  1. go for the similar folder structure of maintaining v1 and v2 to maintain backward compatibility
  2. Since our previous release already support previous versions of edgex, we can make this compatible starting from jakarta. If anybdy wants to use the previous edgex can go for previous releases of ours. Since keeping both would require downloading sdks and other dependencies in vendor directory there by increasing the size of the project

Suggestion of any options above mentioned or else otherwise is welcome!!

What if we take a policy to separate the repo for edge-home-orchestration-go and DataStorage as we discuss in other thread w.r.t. #415?

@nitu-s-gupta Thanks for your analysis!
I think there is very little benefit in supporting both versions.
As @MoonkiHong commented, it would be better to separate DataStorage from edge-home-orchestration-go and make it compatible with 'Jakarta' of edgex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed refactoring Any tasks and issues w.r.t. the code refactoring
Projects
None yet
Development

No branches or pull requests

5 participants