Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross join prevention in base query #122

Open
nZac opened this issue Aug 12, 2019 · 1 comment
Open

Cross join prevention in base query #122

nZac opened this issue Aug 12, 2019 · 1 comment

Comments

@nZac
Copy link
Contributor

nZac commented Aug 12, 2019

Investigate if it is possible to override the base query object such that cross joins would raise an exception unless done explicitly. If this works, we should try to factor it out and put it in keg elements

NOTE: This is xpost from an internal library. The initial work was done by @bladams

@rsyring
Copy link
Member

rsyring commented Aug 12, 2019

Just FYI, Keg doesn't provide the base query. That comes from Flask-SQLAlchemy. We could certainly enhance/replace it.

I'd say the first step to resolving this is to ask on the SQLAlchemy mailing list if it's possible. But maybe even before that we should define a good example use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants