Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider requirement file segmentation #5

Open
rsyring opened this issue May 17, 2024 · 1 comment
Open

Reconsider requirement file segmentation #5

rsyring opened this issue May 17, 2024 · 1 comment

Comments

@rsyring
Copy link
Member

rsyring commented May 17, 2024

I thought it would make sense to have a CI reqs file but it turns out the CI setup is rather complicated due to the various layers involved in testing the demo & bootstrap tasks.

I had intended for mise and reqs to be the two tools installed at the system level. But installing reqs in CI didn't result in them getting on the path. So they ended up being installed in the mise venv as well as in the nox venv for the tests. Seems like it might be a path issue with the cimg/python image as python -m pip install <reqs url> doesn't result in reqs being on the path. Can work on that with #4.

@rsyring
Copy link
Member Author

rsyring commented Jun 13, 2024

Also, for libraries, we aren't going to want to use frozen requirements or have test dependencies in the base requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant