Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PhantomJS stuff #3772

Open
jimmywarting opened this issue Jan 8, 2023 · 6 comments · May be fixed by #3809
Open

Remove PhantomJS stuff #3772

jimmywarting opened this issue Jan 8, 2023 · 6 comments · May be fixed by #3809
Labels
good first issue up-for-grabs

Comments

@jimmywarting
Copy link

I saw this and though, nobody is using phantomjs. it's a headless browser that no real user is using. it was based on webkit and the development have been discontinued. think you should remove this kind of things and instead use something like puppeteer or something.

less.js/packages/less/src/less-browser/index.js

Lines 49 to 56 in eefe33a

// only really needed for phantom
function bind(func, thisArg) {
const curryArgs = Array.prototype.slice.call(arguments, 2);
return function() {
const args = curryArgs.concat(Array.prototype.slice.call(arguments, 0));
return func.apply(thisArg, args);
};
}

PhantomJS is depricated and should not be used anymore.
@matthew-dean
Copy link
Member

Current tests use mocha-headless-chrome which uses Puppeteer, so @jimmywarting feel free to make a PR.

clewarne14 added a commit to clewarne14/less.js that referenced this issue Apr 4, 2023
@clewarne14
Removed outdated PhantomJS function specified in issue less#3772
98d14ff
@clewarne14 clewarne14 mentioned this issue Apr 4, 2023
Closed
1 task
@gadzbi123
Copy link

gadzbi123 commented May 17, 2023 •
edited
Loading

This issue can be closed in reference to #3792

@IAmRiteshKoushik
Copy link

Is this issue still up-for-grabs or has it been resolved ? If someone could help me out here a bit, then I would like to take up the issue and try resolving it.

@TusharP05
Copy link

is someone working on this? I will be happy to take up this issue and contribute.

@iChenLei iChenLei linked a pull request Jul 14, 2023 that will close this issue
Open
3 tasks
@Groot-2001
Copy link

Hey @matthew-dean , I would like to work on this issue!

@IITI-tushar
Copy link

Hello! I wanted to kindly follow up on my PR PR #4283 regarding the removal of PhantomJS references in issue #3772. Thanks for your time and any feedback you can provide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3772 Remove PhantomJS stuff Gourav2580/less.js-gfi4
7 participants
@matthew-dean @jimmywarting @gadzbi123 @IAmRiteshKoushik @TusharP05 @Groot-2001 @IITI-tushar