Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot #3322

Open
sabify opened this issue Dec 4, 2024 · 5 comments
Open

Dependabot #3322

sabify opened this issue Dec 4, 2024 · 5 comments

Comments

@sabify
Copy link
Contributor

sabify commented Dec 4, 2024

Dependabot has been removed in 21f26e7 and I think it is due to PR pollution caused by this bot. I believe it is still worth keeping it but have fewer opened PRs by this bot. It can easily be achieved by: open-pull-requests-limit: 3.

leptos has pretty large dependencies and keeping them up-to-date manually can be time-consuming and keeping them up-to-date is essential for security and stability. By limiting the open pull requests to three, we maintain a manageable workflow while staying current with dependency changes. This not only enhances our project's reliability but also frees up time for the team to focus on new features and improvements.

@OM-HASE
Copy link

OM-HASE commented Dec 4, 2024

@sabify, can I try it.

@gbj
Copy link
Collaborator

gbj commented Dec 4, 2024

Frankly the reason we removed it was that the PRs were, for the most part, completely useless. We do not need to add a lock file in order to add Dependabot in order to have it make PRs to bump patch releases of dependencies. Cargo will do this on its own and the notification spam made actual project maintenance harder.

I'm open to other configurations, but the main goal here would be to limit bot PRs to actual updates.

@benwis
Copy link
Contributor

benwis commented Dec 4, 2024

I agree, I would be in favor of this as a CI step during releases, but mostly it is a giant pain for the day to day

@sabify
Copy link
Contributor Author

sabify commented Dec 5, 2024

It seems the most useful update strategy doesn't work in cargo version of dependabot, versioning-strategy: increase-if-necessary. dependabot/dependabot-core#4009

And because of that some switched to renovate like Astral (astral-sh/uv#2653).

@romanstingler
Copy link

offtopic:
lol empty project

/s/r/qwer ❯ cargo clean                                                                                                          161.797s (main|?) 23:50
     Removed 4346 files, 3.2GiB total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants