New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_missed_batches - issue with RR policy #377

Closed

leondavi opened this issue Jul 20, 2024 · 0 comments · Fixed by #380

Assignees

Owner

leondavi commented Jul 20, 2024 •

edited

Loading

When RR policy is selected, get missed batches returns batches that are assumed as missed wrongly.

Add check for policy of source when calling get missed batches. In case of random missed batches check is not supported.
Add support to RR by checking the number of workers that are targets for this source (given in experiment flow) and calculate all expected batch indexes during experiment.

leondavi assigned ohad123 and NoaShapira8

NoaShapira8 linked a pull request

that will close this issue

Fix missed batches rr #380

Merged

leondavi closed this as completed in #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment