Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename path_length attribute of Path and Surface classes #142

Open
jobdewitte opened this issue Dec 11, 2024 · 2 comments
Open

Rename path_length attribute of Path and Surface classes #142

jobdewitte opened this issue Dec 11, 2024 · 2 comments
Milestone

Comments

@jobdewitte
Copy link
Collaborator

jobdewitte commented Dec 11, 2024

Problem statetment

Right now the class attribute of the Path and Surface class in the geometry module that represent the length of the parameter intervals in the 1D parameter space are chararacterized as path_length . This is easily confused with the length of the resulting path in the 3D target space and will likely lead to inconsistencies in further development.

Proposed Solution

Rename the path_length attribute to something more accurate, such as param_range, _size or _extent and reserve path_length for the length of the curve in target space.

@jobdewitte
Copy link
Collaborator Author

This was a bit hasty. I'll come back to it later.

@leon-vv leon-vv added v0.9 and removed v0.9 labels Dec 12, 2024
@leon-vv leon-vv added this to the v0.9 milestone Dec 12, 2024
@jobdewitte
Copy link
Collaborator Author

What should happen is that the parametrization should no longer always be [0, path_length] but rather [0, u_max]. This is both advantagous from a UX and development perspective. For instance, it is much more natural to parametrize angles using [0,2pi]. However, path_length is used in Mesher, so we have to compensate for that. @leon-vv thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants