You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the class attribute of the Path and Surface class in the geometry module that represent the length of the parameter intervals in the 1D parameter space are chararacterized as path_length . This is easily confused with the length of the resulting path in the 3D target space and will likely lead to inconsistencies in further development.
Proposed Solution
Rename the path_length attribute to something more accurate, such as param_range, _size or _extent and reserve path_length for the length of the curve in target space.
The text was updated successfully, but these errors were encountered:
What should happen is that the parametrization should no longer always be [0, path_length] but rather [0, u_max]. This is both advantagous from a UX and development perspective. For instance, it is much more natural to parametrize angles using [0,2pi]. However, path_length is used in Mesher, so we have to compensate for that. @leon-vv thoughts?
Problem statetment
Right now the class attribute of the
Path
andSurface
class in thegeometry
module that represent the length of the parameter intervals in the 1D parameter space are chararacterized aspath_length
. This is easily confused with the length of the resulting path in the 3D target space and will likely lead to inconsistencies in further development.Proposed Solution
Rename the
path_length
attribute to something more accurate, such asparam_range
,_size
or_extent
and reservepath_length
for the length of the curve in target space.The text was updated successfully, but these errors were encountered: