Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbans is vulnerable to steamid spoofing #375

Open
sapphonie opened this issue Mar 25, 2023 · 2 comments
Open

gbans is vulnerable to steamid spoofing #375

sapphonie opened this issue Mar 25, 2023 · 2 comments
Labels
bug Something isn't working Sourcemod

Comments

@sapphonie
Copy link

https://github.com/leighmacdonald/gbans/blob/master/sourcemod/scripting/gbans/ban.sp#L39-L47

Same issue with SourceBans, clients can spoof being unauth'd and be unbannable. Upcoming StAC 6.0 resolves this (StAC side, not gbans side) by doing magic with connect extension. If you'd like me to provide a native to query given a client index, let me know. Otherwise I can point you in the direction of the still beta unfinished code

@leighmacdonald
Copy link
Owner

@sapphonie I can try it out if you are wanting testing, is it just the stac beta branch?

@sapphonie
Copy link
Author

Err, it's more that GetClientAuthId may return false etc if the client is spoofing being unconnected. i'm fairly sure you could get the steamid 100% of the time by setting verify = false w/GetClientAuthId since you do have the connect extension, but I'm going to double check with the author of the ext who's obviously more familiar with Steam's auth methodology, and likely provide a native with stac regardless.

@leighmacdonald leighmacdonald added bug Something isn't working Sourcemod labels May 1, 2024
@leighmacdonald leighmacdonald moved this to In Progress in Uncletopia May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Sourcemod
Projects
Status: In Progress
Development

No branches or pull requests

2 participants