Development meeting held @ 3PM UTC in grincoin#general channel on Keybase. Meeting lasted ~ 110 min.
Notes are truncated, and conversations sorted based on topic and not always chronological. Quotes are edited for brevity and clarity, and not always exact.
Community attendance:
- antiochp
- anynomous
- bladedoyle
- dtavarez
- hashmap
- i1skn
- jaspervdm
- joltz
- kurt2
- lehnberg
- paouky
- phyro
- quentinlesceller
- smokeking80
- timtimbo
- tromp
- vegycslol
- yeastplume
(apologies if I missed someone - submit a PR or contact @lehnberg to add)
The proposed agenda was reviewed and accepted without any additions.
Related discussion:
-
antiochp: Just commented over there.
-
lehnberg: @antiochp what's meant by that?
core == council
no? -
antiochp: That's a good question I think. We can have core devs that are not on the council right? And council members not necessarily in core. Its a little ambiguous.
-
paouky: Even I didn't know there's a difference.
-
lehnberg: We're not talking about core devs. We're talking about membership to the core team, which was previously called council. These guys: https://grin.mw/governance#core-team. This is a relevant read https://github.com/mimblewimble/grin-rfcs/blob/master/text/0002-grin-governance.md.
-
π: anynomous
-
antiochp: Ok then core team vs core devs is really confusing. (And that's coming from somebody on both.)
- paouky: How do you see the difference?
-
anynomous: Maybe go back to 'council' and use core for dev only.
-
lehnberg: Yes, and what's the core the devs are working on? The rust implementation is core?
-
antiochp: These are all good questions.
-
lehnberg: Tbh, I was the one who proposed the name change to core. And I've since come to hate the name core team. Violently.
-
paouky: I'm seriously in favor of calling it the council.
-
lehnberg: I'd second that. Let's think about how we can go back to that name (after the meeting) and see if we can come up with some reasonable proposal for doing so. Was a bad move then, and I should have been stopped. It's all your fault!
-
anynomous: Go back to council, and use core for core developers, which we can now define. It was new to me, that core was also used for non developers. And make a clear list of what the responsibilities are of core and of the council.
- π: paouky, dtavarez
-
-
antiochp: To be entirely honest I had no idea we changed it from "council" to "core team". And have always used "core" to mean the core dev team.
- lehnberg: What's the core dev team?
- antiochp: Those with commit rights to the repo.
- tromp: I have no commit rights but consider myself a core dev.
- antiochp: Ok yeah what @tromp said - its a rough overlap with commit rights, but not 100%.
- lehnberg: Commit rights is not what determines what gets merged. It's just the action of merging something, that hopefully is in line with some predetermined process.
- π: tromp
-
paouky: I'd say we can define core devs as regular contributors to the rust repos.
None.
3. @i1skn funding request
-
lehnberg: Floor is yours @i1skn for any statements, and for others to ask questions.
- π: antiochp, dtavarez, phyro, quentinlesceller, lehnberg
-
i1skn: Well, thanks @lehnberg! I do not feel the need to do any statements, I think I wrote everything in the post above. But I'm happy to answer any questions here:).
-
lehnberg: Is the request for full time or part time work?
- i1skn: It's a part time work.
- anynomous: Which percentage of full time equivalent work.
- π: kurt2
- i1skn: My calculations were based on working around 16h a week. It's actually 4 months, and It would depend on the needs of the wallet in the next year. Right now there are some features, which require significant effort, so this request exists. But before more than a year I was working on the project as well. Let me know if that answers your questions or not.
- anynomous: Ok, so 7500 per month for full time work equivalent.
- phyro: I think it's ~10k for 40h/week.
- i1skn: No, it's 10k full time equivalent.
- anynomous: Ok, but that would be 3 months. With 4 months 400040/163/4 = 7500.
- i1skn: My plan was to receive 4k a month for the period of 4 months.
- anynomous: A ok. Clear.
-
dtavarez: @i1skn are you planning to keep working on the wallet after these 3 months?
- π: quentinlesceller, lehnberg, kurt2, timtimbo, paouky, phyro
-
lehnberg: Do you intend to ensure ironbelly will be compatible with grin v5.0.0 (post hf4)? I see the funding expires in december, hard fork is in january, so it's a bit unclear.
- paouky: (and for future changes i.e. Elimate finalize step rfc).
- kurt2: Yes, relevant question. If by luck the eliminate last step is secure and that we can know it soon enough (3 or 6 months), it is worth considering that all the implementation done for current tx building does not become too much legacy after we intend to port the change into grin.
- i1skn: Yeah, my intent is to port everything new introduced recently and make compatible with the next hf.
- π: lehnberg, quentinlesceller
-
lehnberg: To be clear, it's 4k eur, 4 months (sep, oct, nov, dec), is that right?
- i1skn: Yeah, starting from mid sep and ending by the time close to hf considering that right now is 8 sep:)
-
anynomous: So your rate is equivalent of that of the core devs from grin, 10k a month..
- i1skn: Yeah, let me know if you think it's unfair.
-
lehnberg: So 4 months starting from date of approval?:)
- i1skn: Well, that makes sense to me. Does it to you?:)
- lehnberg: Yes, sure. Just want to get everyone on the same page.
-
paouky: I'll be honest I think it's quite a lot. But it's hard to judge.
-
anynomous: Same here, even for the core devs I find 10k a bit hard to swallow.
-
bladedoyle: Senior software devs make about $160k/year in silicon valley.
- paouky: Do you expect an open source project to pay the same as a tech unicorn in one of the most expensive region in the world?
-
phyro: 10k rate for a good developer is not uncommon.
-
anynomous: True, but not everyone who is good gets paid that much. Meaning you can get a certain amount in industry does not automatically mean it should become default. Anyhow, I know plenty of people disagree with me on this.
-
antiochp: You could probably double that at least for a "unicorn" to be fair.
-
bladedoyle: 160k plus benefits. Iβm just offering a reference not voting.
-
paouky: If you devs think it's fair, I'm on board. I have no developer experience and never was paid for it so...
-
anynomous: Maybe, but that would automatically assume you are the best of the best and the unicorn wants you. Anyhow, I do think the country someone should live in should be taken into account. Theoretically everyone can earn loads while working remotely for a us based company.
-
kurt2: 3k or 4k seems fair to me, but I am trying to see if the work will not become too much legacy if we are able to change tx building soon. I do not know much the answer to that since the infra might be flexible enough to not re-do everything, or too much.
- π: paouky, phyro, anynomous
- phyro: You mean 3k or 4k monthly for 16h right?
- kurt2: Yes.
-
i1skn: Well, I do not see a challenge to bring something from grin-wallet to ironbelly if it's not relating to i/o (files, tor, setting up http server etc.).
-
tromp: It's not realistic to expect round reduction to be implemented by hf4. The new signature scheme must be thoroughly reviewed and vetted.
- π: phyro
- kurt2: Yes, but less than a year or 9 months might be enough, if we hired a cryptographer for a few weeks or a month to review it for example.
-
anynomous: Where do you live (country) @i1skn?
- i1skn: Germany.
- paouky: I don't think country is a good parameter. The important thing is the result we get. I do not mind if a good dev from zimbabwe does it.
- π: phyro, timtimbo, quentinlesceller
- anynomous: True, just put it as information.
-
lehnberg: Are you employed full time today @i1skn?
- i1skn: Yes.
-
dtavarez: For context, 4k monthly is the minimum for a senior developer in germany.
- quentinlesceller: Full time.
- anynomous: https://blog.honeypot.io/how-much-do-developers-earn-in-germany/
-
anynomous: If the results are good and support stays after the next hardfork, the money is well spend.
-
i1skn: Just to be clear. My calculation was like that - I took the rate from the core devs requests and applied part time on it.
-
lehnberg: Okay, at this time we're running a bit over.
-
i1skn: Ironbelly is using all crypto logic from
grin-wallet
. So if Something is related to pure data manipulation it should be easily portable to ironbelly.- π: antiochp, quentinlesceller
-
i1skn: Also, there was at least one example of me back-contributing to
grin-wallet
when I've implemented fee estimation priod to transaction on ironbelly and it did not exist ingrin-wallet
at the time. I'm planning to keep it this way if I implement something new or fix a bug. -
quentinlesceller: I'm personally in favor of this funding request @i1skn. However having both a full time job + that is going to be a lot.
-
yeastplume: I am as well.. Keep in mind ivan's been working on ironbelly since before grin was launched. I'm okay with seeing him get some funding to continue his work based on his contribution to date.
- π: lehnberg, quentinlesceller, phyro, paouky, joltz, hashmap, smokeking80
-
lehnberg: okay, so about here's the time someone needs to object strongly in order for this to be reconsidered.
-
phyro: I do think people should not just copy core devs rates though. It is the maximum rate for the best full stack developers in germany, so I am also against taking it as a standard. Having said that I am still in favour of funding @i1skn.
- π: anynomous
- timtimbo: https://forum.grin.mw/t/question-about-funding-gui-wallets-like-ironbelly-or-grin/7559.
- paouky: It's the standard from now on.
- yeastplume: Right, this amount shouldn't be a precedent for anything.
- π: quentinlesceller
- paouky: It is though. Same reason every core dev gets 10k. David Tavarez asked 4k.
- yeastplume: Disagree, the pool of people who've worked on grin since inception is small. I'm willing to gloss over the amount for now as a recognition of service.
- paouky: If another person wants to contribute to docs sometime in the future, he'll ask around my request.
- antiochp: I think earlier in this process might have been a better time to bring discussions around rates up.
- paouky: This is not an objection to rates.
- yeastplume: And what antioch just said.
- anynomous: Sure, but I do think we should have the same consideration for david tavarez.
- paouky: Its just a statement contradicting yours. Not saying the rates are wrong, just that it is a precedent. I think we can end the discussion here though, lets move on.
- π: anynomous
-
lehnberg: Aside from the above expressed concerns, do we have any objections? Or any counter-proposals?
-
kurt2: What about 3 or 3.5k for this request, and 4.5 or 5k for future work on grin wallet to implement eliminate last step or any further improvement in the middle term after hf. Based on results of the upcoming 4 months.
-
anynomous: Some result/reward based payment would not be bad, especially since it might be hard to get everything done in time next to full time work. Anyhow, I am ok both ways, trust or reward based payment.
-
paouky: These are not proposals for gov meeting though, should have been proposed earlier I believe. Now it's approve / not approve.
- π: quentinlesceller, antiochp
-
paouky: And I think it's approved.
- π: anynomous
-
phyro: I'm not against the rate itself btw, I just find it weird the way it was picked. I don't think we should be lowballing here, there was time to do his before. It's nice that we have an existing community member who already knows what they're doing and are using grin-wallet from the backend so it's still definItely a yes from me.
-
quentinlesceller: I think later on, end of the year or beginning next year, we should try to think a bit more about the rates so we try to stay as fair as possible with everyone involved.
- π: kurt2, timtimbo
-
yeastplume: I'm okay with this for now, it's our collective fault for not hashing though these amount issues earlier. It's a yes from me but It cannot set a precedent, and we need actions to discuss how to deal with these issues in future.
- π: paouky, phyro, anynomous
-
anynomous: It is a yes from me to fund @i1skn based on his previous contributions.
-
joltz: I'm grateful to have more interest and talent focusing resources on improving grin. Ivan has been with grin since the beginning and I'm happy to have him more involved. I was thrown off a bit today when I see that the request is for part time work and that you already have a full time job. For the future I think it would be helpful to frontload with that information in your proposal. That being said, few people have been contributing to grin for this long and I support Ivan's request for work.
- π: quentinlesceller, tromp, dtavarez, phyro, lehnberg, anynomous, yeastplume, paouky
-
lehnberg: Okay - nobody's saying no - I call consensus for approve.
- π: phyro, quentinlesceller, paouky, joltz, smokeking80
- quentinlesceller: π
-
lehnberg: Congrats @i1skn.
- π: paouky, phyro, quentinlesceller, joltz, anynomous, smokeking80
-
i1skn: Thanks everyone who's participated! I've noted the feedback and will try to achieve everything I've stated in the request.
- π: anynomous, kurt2, yeastplume
- dtavarez: Thanks to you!
4. @davidtavarez funding request
-
lehnberg: Floor is open for questions, let's try to keep this one tighter on time, still have a lot of points to go through! Request is for
eur 4k * 3 months
. -
dtavarez: 3 months. First, I want to clarify... I'm requesting 4k/month for 3 months: September, october and november. I won't make a commitment for the whole month of december, that is why is not included. The mobile wallet will be full compatible with grin 5.0 and I'm not planning to release it publicly before january 2021. Of course, any developer will be able to clone the repository, compile it and run it. Everything will be well documented. I will need to invest on buying some devices for testing, including phones, tablets and a a raspberry pi, and I would like to use all my next holidays to boost up the development.
- π: yeastplume, quentinlesceller
-
dtavarez: I have no plans to leave grin, that means I will keep working after this process, with a small break on december to avoid a burnout.
- π€©: joltz, quentinlesceller, kurt2
-
dtavarez: Some features of the mobile wallet won't be compatible with ironbelly for a while, but I'm open to contribute with ironbelly after these features become stable, like transactions via nfc.
- i1skn: From my side I'm willing to collaborate, so both projects are compatible (taking into consideration, that ironbelly should be compatible with
grin-wallet
as well).
- i1skn: From my side I'm willing to collaborate, so both projects are compatible (taking into consideration, that ironbelly should be compatible with
-
dtavarez: (pre-cooked answers π)
- π: kurt2, antiochp, quentinlesceller
- lehnberg: πfor the wall of text!
-
tromp: I wholeheartedly support david's rather modest request.
-
yeastplume: As do I.
-
lehnberg: @dtavarez
- What country Are you based in?
- Are you employed full time already?
- Is this request for full time or part time?
- π: quentinlesceller, anynomous
- dtavarez:
- I'm based in germany
- currently, yes... But not sure for the next months.
- around 30 hours per week and on weekends around 16 hours.
- π: kurt2
- quentinlesceller: 8 hours per day on weekends?
- dtavarez: Yes.
- πͺ: joltz, kurt2, kurt2
- quentinlesceller: Wow that's dedication.
- dtavarez: It's just 3 months... But also that's why I want to have part of december to disconnect myself a bit.
-
anynomous: Same here, just wondering if the funding/months will be enough since it also involves work in the backend.
-
kurt2: @dtavarez I don't remember exactly if you stipulated on your post on the forum, do you plan to make a full node wallet feature in your working period?
- dtavarez: Full node wallet.
- kurt2: Great!
-
i1skn: Will it support "remote node" mode for users with limited bandwidth or slow devices?
- dtavarez: Technically possible, yes.
-
anynomous: I still am questioning if the time you are asking funding for will be enough since it will involve work on the grin++ node itself as well, so not just the front-end.
-
phyro: I support this request as well π burkett was saying he might leave at some point (hope he doesn't), but if this happens, does the fact that he might not maintain the grin++ node codebase impact this project?
- π: anynomous
- dtavarez: Great question... In case david leaves, I'm more than willing to take ownership of grin++ but that's something unclear right now; everything will remain open source.
-
quentinlesceller: Why not use grin-wallet as backend @dtavarez? I don't have anything against g++ just asking.
- π: phyro
- dtavarez: I consider that the community enriches with more options and it helps to have a bit more of decentralization. There are other pros too that I would like to discuss but I would need to have another space for that other than this.
-
anynomous: I am in full favour of funding you, but I do think the planning for all those features is optimistic, lets see. Maybe a 4th month would be prudent.
-
lehnberg: okay, so about here's the time someone needs to object strongly in order for this to be reconsidered.
-
quentinlesceller: @dtavarez can you answer my question above about the choice of backend?
- lehnberg: Thanks for this, I'd be curious to hear these reasons too fwiw, perhaps you could write in #dev later?
- dtavarez: Yes.
-
lehnberg: Okay - nobody's saying no - I call consensus for approve.
- π: phyro, antiochp, quentinlesceller, i1skn, smokeking80, joltz
-
lehnberg: Congrats @dtavarez πΎ.
- dtavarez: Muchas gracias:).
-
phyro: Congrats π
-
quentinlesceller: Congrats @dtavarez.
-
joltz: Beyond excited to have two new people helping build grin in a more empowered capacity, thanks to both of you @dtavarez and @i1skn.
- π: i1skn
-
paouky: looking forward to seeing the grin++ mobile wallet! Such an empire.
- π: dtavarez
-
quentinlesceller: Indeed.
-
kurt2: Congratulation to dtavarez. I like the intented dedication and motivation for This project with all the expected hard work, and think it can really benefit grin ecosystem. I salute the core team for supporting the request. This is not everyday that we can see this humility and will to cooperate with another implementation (here financially) from a project's reference implementation. Respects.
- π: dtavarez
-
phyro: It would be fun if he objected now.
- π: paouky
-
lehnberg: Cliff-notes for the confused: https://github.com/mimblewimble/grin-rfcs/blob/master/text/0002-grin-governance.md#organization--processes first point:
ignotus peverell, as creator of grin, is considered bdfl and leader of the core team.
.Motivation for removal:
davidburkett commented 4 days ago decentralized projects should not have a "benevolent dictator for life". I think keeping that statement, while probably meant as merely a nod to his awesome work starting this project, does more harm than good.
-
lehnberg: My comment on the pr:
i'm +1. Others in the core team have objected to this in the past, we never got around to change it.
while probably meant as merely a nod to his awesome work starting this project
not only. When this RFC was adopted, there was still an expectancy that igno might be coming back, and nobody was comfortable restricting igno's authority over the project at the time.
-
quentinlesceller: I think we kept it as a david said a nod to the awesome work that he did with grin.
-
paouky: Indeed seems reasonable to remove it.
-
antiochp: If we get rid of this we should maybe add a line to the "credits" to replace this.
- π: quentinlesceller, lehnberg, joltz, timtimbo, vegycslol
- quentinlesceller: Yeah but maybe that's not the right place?
- lehnberg: Credits in
readme.md
. Of grin repo. - antiochp: Yes, or somewhere similar.
- lehnberg: I think it's a good place personally, very fitting as they were the ones who created that section in the first place afaik.
- quentinlesceller: π
-
tromp: It's become rather inaccurate, so I'm fine with removal. Igno is no longer leading much.
-
paouky: I'm kind of surprised he agreed to be named bdfl in the first place.
- lehnberg: He didn't. This was post departure.
- paouky: Ah ok.
- quentinlesceller: The whole structure appeared after. But not the council.
- lehnberg: So yeah. And for a decentralized project to have a bdfl that is not there, doesn't really make a lot of sense probably.
- paouky: Ye I remember the ol' technocratic council.
-
lehnberg: And others (like @yeastplume iirc) have questioned this line in the past too.
-
kurt2: I have nothing to keep bdfl naming for igno. It's rather a funny meme today at this point.
-
lehnberg: So yeah, is there any objections to approving this pr?.
-
yeastplume: I have raised this before, itβs weirdly cultish at this stage so okay with the change.
-
lehnberg: Generally speaking, the entirety of rfc#0002 probably needs a lot of rework at this point.
- π: paouky
-
lehnberg: Okay I take that as a lgtm.
-
paouky: I do not mind working on this with you and others.
- π: quentinlesceller
- lehnberg: Sounds good!
-
lehnberg: @hashmap and @jaspervdm are you there?
-
jaspervdm: I am.
- π: lehnberg, smokeking80, quentinlesceller, joltz, antiochp, phyro, vegycslol
-
quentinlesceller: https://forum.grin.mw/t/request-for-funding-jaspervdm-march-may-2020/7074/10?u=quentinlesceller.
-
tromp: In view of jasper's recent actions, we can keep him on.
- π: antiochp, lehnberg, phyro, yeastplume, quentinlesceller, vegycslol
-
kurt2: Maybe we can make up honorary titles for former member, as a mean to honor their past contributions to the project. And leave them listed as such on the website/github/doc.
- lehnberg: Grin alumni? Grinlumni?
- kurt2: Something like that: ).
- paouky: Haha, that's a slippery slope, we have way too many past contributors.
- kurt2: This is something less "cold" and I think they would appreciate such tItles. It dods not hurt and can incentive some return to the project or friendly collaboration in the future, but not urgent.
- π: phyro
-
lehnberg: Okay, so are there any objections to @hashmap's removal from the core team?
- phyro: I think he himself gave a thumbs up.
- lehnberg: That's right.
-
lehnberg: So that's that then, clubbed.
-
lehnberg: @hashmap wherever you are, it's been a pleasure working with you so far, and hope to see you on github soon again.
- π: kurt2, smokeking80, quentinlesceller, yeastplume, joltz, tromp, vegycslol
- lehnberg: @paouky is there sth urgent to update on documentation? If not I propose we kick on with that in #docs. And others are free to join.
- paouky: Was gonna say, nothing to discuss, will post an update on the forum very soon for whoever is interested.
- π: quentinlesceller
- lehnberg: mimblewimble/site#222:
- tweak of code of conduct
- moving to website
- if merged, all the other repos will have a
code_of_conduct.md
that links to this website one, so there's a single source of truth across all repos. It's been up for 26 days, feedback has been incorporated.
- lehnberg: Can I merge?
- π: joltz, yeastplume, quentinlesceller, phyro, paouky
- quentinlesceller: Yes.
-
lehnberg: In terms of rfcs, noteworthy is that there are two new ones by @tromp:
-
split one-sided transactions in pure mw mimblewimble/grin-rfcs#64
-
fix-fees mimblewimble/grin-rfcs#63
Please devour these and give them the scrutiny they deserve.
-
-
tromp: First one is pretty dead already as payment proofs seem impossible. So just keep it as documented failure.
- lehnberg: If so, will you close the pr? (with reason for posterity).
- tromp: Will keep open a bit to gather comments. Can close in a week or two.
- lehnberg: Sounds good.
-
tromp: For fees, I see no good reason to have two sets of weights, one of which is quite arbitrary, and one which in consensus. When the major requirements on fees are that they are dominated by #outputs, and that they are ideally compatible with miner incentives.
- π: vegycslol
- lehnberg: With everything else on today's agenda, I've not even mentioned this forum post I wrote last weekend: https://forum.grin.mw/t/dismantling-the-core-team-and-governance-structure/7801. It's very much related to governance, I urge you all to get involved if you have ideas.
Meeting adjourned.