Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metrics into graph_metrics #33

Open
LudovicPatey opened this issue Oct 6, 2019 · 1 comment
Open

Rename metrics into graph_metrics #33

LudovicPatey opened this issue Oct 6, 2019 · 1 comment
Assignees
@chreman

Comments

@LudovicPatey
Copy link

In dramalyzer.py, you define a property called metrics, and then refer to it only as graph_metrics, raising an error. Please, rename metrics into graph_metrics to fix the issue.
@chreman chreman self-assigned this Oct 9, 2019
@chreman
Copy link
Collaborator

chreman commented Oct 9, 2019

Hello, thank you for raising this issue. I haven't had a look at the source code in a long time, can you provide me with a more precise error message?
If this is only a property naming bug and you are confident that the issue is solved by your proposal without side effects I very happily welcome a pull request, as this project is currently not regularly maintained.
Thank you for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chreman chreman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LudovicPatey @chreman