-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing bracket #126
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 28.52% 28.52%
=======================================
Files 37 37
Lines 3527 3527
=======================================
Hits 1006 1006
Misses 2521 2521 ☔ View full report in Codecov by Sentry. |
How did the the property function break during my debugging? I never touched this code??
The issue with the plotting is related to |
Sry i Had a Mistake in my Comment. You did not change the Code you Changed how the ctc_drift_expression is passed to the Function. I passed the expression work brackets, you Save it and pass it without brackets. So we could also Change the Expression in the config but adding the brackets here is the Most robust Solution if something is changed again. This other Problem i have to admit I did Never encounter and After this PR also did not encounter again. Your error is I think behause I have a fixed Window for the Plot and the Expression Bug Gas the Effekt That not a Single Event is in That window. Without one Element the Plot fails. But when the Plot geht’s valid values they work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you continue discussing the NaN
plotting issue somewhere else, for example by opening a new issue?
I feel like this PR fixes a very obvious and straight-forward-to-fix bug and should be merged ASAP.
Clarify the correct placing of the brackets
I created a new issue |
I will go ahead and merge since I want to test this on data |
Hi, I noticed that something strange was happening with the LQ processor. I noticed that the dirft time correction property function got broken during Florians debugging. Previoues to this PR the
lq_ctc_correction
() function expected thectc_driftime_expression
to have brackets. I now changed this so that the function also returns the correct property function ifctc_driftime_expression
does not have explicitly brackets.@theHenks I also noticed that during your debugging you encountered some problems with my plots. This happened because the the wrong ctc correction broke them. With this fix they all work again as intended and it would suggest to include the
lq_cut
plot again as it is currently commented out. Except you had another reason the remove it from the lq processors