Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing bracket #126

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Added missing bracket #126

merged 2 commits into from
Feb 28, 2025

Conversation

DaGeibl
Copy link
Contributor

@DaGeibl DaGeibl commented Feb 28, 2025

Hi, I noticed that something strange was happening with the LQ processor. I noticed that the dirft time correction property function got broken during Florians debugging. Previoues to this PR the lq_ctc_correction() function expected the ctc_driftime_expression to have brackets. I now changed this so that the function also returns the correct property function if ctc_driftime_expression does not have explicitly brackets.

@theHenks I also noticed that during your debugging you encountered some problems with my plots. This happened because the the wrong ctc correction broke them. With this fix they all work again as intended and it would suggest to include the lq_cut plot again as it is currently commented out. Except you had another reason the remove it from the lq processors

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.52%. Comparing base (2ba3dd2) to head (a83d3f2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   28.52%   28.52%           
=======================================
  Files          37       37           
  Lines        3527     3527           
=======================================
  Hits         1006     1006           
  Misses       2521     2521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann fhagemann added the bug Something isn't working label Feb 28, 2025
@theHenks
Copy link
Collaborator

Hi, I noticed that something strange was happening with the LQ processor. I noticed that the dirft time correction property function got broken during Florians debugging. Previoues to this PR the lq_ctc_correction() function expected the ctc_driftime_cutoff_method to have brackets. I now changed this so that the function also returns the correct property function if ctc_driftime_cutoff_method does not have explicitly brackets.

How did the the property function break during my debugging? I never touched this code??

@theHenks I also noticed that during your debugging you encountered some problems with my plots. This happened because the the wrong ctc correction broke them. With this fix they all work again as intended and it would suggest to include the lq_cut plot again as it is currently commented out. Except you had another reason the remove it from the lq processors.

The issue with the plotting is related to NaN values within your Vectors to be plotted, in particular the histogram2d plots. I don't see how this PR is fixing this?

@DaGeibl
Copy link
Contributor Author

DaGeibl commented Feb 28, 2025

Sry i Had a Mistake in my Comment. You did not change the Code you Changed how the ctc_drift_expression is passed to the Function. I passed the expression work brackets, you Save it and pass it without brackets. So we could also Change the Expression in the config but adding the brackets here is the Most robust Solution if something is changed again.

This other Problem i have to admit I did Never encounter and After this PR also did not encounter again. Your error is I think behause I have a fixed Window for the Plot and the Expression Bug Gas the Effekt That not a Single Event is in That window. Without one Element the Plot fails. But when the Plot geht’s valid values they work.

fhagemann
fhagemann previously approved these changes Feb 28, 2025
Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you continue discussing the NaN plotting issue somewhere else, for example by opening a new issue?
I feel like this PR fixes a very obvious and straight-forward-to-fix bug and should be merged ASAP.

@fhagemann fhagemann dismissed their stale review February 28, 2025 15:48

Clarify the correct placing of the brackets

@theHenks
Copy link
Collaborator

Can you continue discussing the NaN plotting issue somewhere else, for example by opening a new issue? I feel like this PR fixes a very obvious and straight-forward-to-fix bug and should be merged ASAP.

I created a new issue

@theHenks
Copy link
Collaborator

I will go ahead and merge since I want to test this on data

@theHenks theHenks merged commit c0b6507 into legend-exp:main Feb 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants