-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated LQ sideband selection logic #124
Conversation
…ion; added plot recipe to monitor sidebandregions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 28.52% 28.39% -0.13%
==========================================
Files 37 37
Lines 3527 3564 +37
==========================================
+ Hits 1006 1012 +6
- Misses 2521 2552 +31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Did you test this on real data already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
@theHenks I think there is a GitHub issue, or I do sth Wrong. On my DaGeibl/Main Branch there is the pushed Committee That resolves Felix Comments. Of I Look at this PR i See That its still „Processing Updates“. Did you encounter sth Like That before? |
Some times a good old force push fixes things ^^ |
This pull request changes how the LQ sideband are generated. Currently the peak is defined as 4.5 dep_sigma(value from calibration) around the literature value of the DEP. The sidebands lie between 4.5 and 9 sigma on both sides of the peak band. For Detectors with low resolution this can result in a case where the sidebands reach into the 212-Bi FEP. To avoid this, I moved the both sidebands to the energies below the DEP.
Plot of Detector with normal energy res:

Plot of Detector with bad energy res before PR

Plot of same Detector after PR

Also added with this PR is a recipe for the plot above, that can be implemented into the lq_processors