Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit performance warning when creating OptimizationProblem #122

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

fhagemann
Copy link
Contributor

@fhagemann fhagemann commented Feb 25, 2025

Tired of seeing this warning?
image

Say no more. We can replace [] by () (Tuple instead of Vector) to avoid this warning:
image

This is done everywhere in LegendSpecFits in this PR.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.18%. Comparing base (10e8e19) to head (73f84cb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aoe_ctc.jl 0.00% 1 Missing ⚠️
src/ctc.jl 0.00% 1 Missing ⚠️
src/lqfit.jl 0.00% 1 Missing ⚠️
src/singlefit.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   29.24%   29.18%   -0.06%     
==========================================
  Files          37       37              
  Lines        3447     3447              
==========================================
- Hits         1008     1006       -2     
- Misses       2439     2441       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann fhagemann requested a review from theHenks February 25, 2025 12:25
@fhagemann fhagemann self-assigned this Feb 25, 2025
@fhagemann fhagemann added the performace Increase in performance label Feb 25, 2025
Copy link
Collaborator

@theHenks theHenks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this also reduces the messages I see in the dataflow by a lot

@theHenks theHenks merged commit d58a59e into main Feb 25, 2025
13 checks passed
@theHenks theHenks deleted the optim_warning branch February 25, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performace Increase in performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants