();
if (attempt.Success)
{
value = attempt.Result;
diff --git a/src/Umbraco.Community.Contentment/DataEditors/CheckboxList/checkbox-list.css b/src/Umbraco.Community.Contentment/DataEditors/CheckboxList/checkbox-list.css
index 064cc166..e83b2bd4 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/CheckboxList/checkbox-list.css
+++ b/src/Umbraco.Community.Contentment/DataEditors/CheckboxList/checkbox-list.css
@@ -11,11 +11,7 @@
margin-bottom: 8px;
}
-.contentment .umb-form-check__text {
- margin-top: 1px;
+.contentment .umb-form-check__text small {
+ display: block;
+ padding-top: 0;
}
-
- .contentment .umb-form-check__text small {
- display: block;
- padding-top: 0;
- }
diff --git a/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.html b/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.html
index 68827b4d..5ba8ccc7 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.html
+++ b/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.html
@@ -12,7 +12,7 @@
description="vm.populate(item, 'description')"
sortable="vm.sortable"
allow-remove="vm.allowRemove"
- allow-edit="vm.allowEdit"
+ allow-edit="vm.allowEdit[item.key]"
on-remove="vm.remove($index)"
on-edit="vm.edit($index)">
diff --git a/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.js b/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.js
index f2178f09..03bcf625 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.js
+++ b/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.js
@@ -18,7 +18,6 @@ angular.module("umbraco").controller("Umbraco.Community.Contentment.DataEditors.
items: [],
maxItems: 0,
disableSorting: 0,
- allowEdit: 1,
allowRemove: 1,
enableFilter: 0,
orderBy: "name",
@@ -46,13 +45,14 @@ angular.module("umbraco").controller("Umbraco.Community.Contentment.DataEditors.
});
config.itemLookup = {};
+ vm.allowEdit = {};
config.items.forEach(function (item) {
config.itemLookup[item.key] = item;
+ vm.allowEdit[item.key] = item.fields && item.fields.length > 0;
});
vm.allowAdd = (config.maxItems === 0 || config.maxItems === "0") || $scope.model.value.length < config.maxItems;
- vm.allowEdit = Object.toBoolean(config.allowEdit);
vm.allowRemove = Object.toBoolean(config.allowRemove);
vm.sortable = Object.toBoolean(config.disableSorting) === false && (config.maxItems !== 1 && config.maxItems !== "1");
diff --git a/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.overlay.html b/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.overlay.html
index 2885a406..0c5f1794 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.overlay.html
+++ b/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.overlay.html
@@ -55,7 +55,7 @@
Unable to find the editor for this configuration value.
-
+
There are no fields for this item.
diff --git a/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.overlay.js b/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.overlay.js
index 0a34d3e1..84610d59 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.overlay.js
+++ b/src/Umbraco.Community.Contentment/DataEditors/ConfigurationEditor/configuration-editor.overlay.js
@@ -60,6 +60,10 @@ angular.module("umbraco").controller("Umbraco.Community.Contentment.Overlays.Con
$scope.model.size = editor.overlaySize;
}
+ if (!item.value) {
+ item.value = {};
+ }
+
vm.title = "Configure " + editor.name;
vm.editor = Object.assign({}, editor);
diff --git a/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListConfigurationEditor.cs b/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListConfigurationEditor.cs
index 58b25da3..71ddcf3c 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListConfigurationEditor.cs
+++ b/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListConfigurationEditor.cs
@@ -42,7 +42,7 @@ public DataListConfigurationEditor(ConfigurationEditorUtility utility)
Fields.Add(
DataSource,
"Data source",
- "Select and configure the data source.",
+ "Select and configure a data source.",
configEditorViewPath,
new Dictionary(defaultConfigEditorConfig)
{
@@ -52,7 +52,7 @@ public DataListConfigurationEditor(ConfigurationEditorUtility utility)
Fields.Add(
ListEditor,
"List editor",
- "Select and configure the list editor.",
+ "Select and configure a list editor.",
configEditorViewPath,
new Dictionary(defaultConfigEditorConfig)
{
diff --git a/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListDataEditor.cs b/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListDataEditor.cs
index f3265288..22137f86 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListDataEditor.cs
+++ b/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListDataEditor.cs
@@ -15,7 +15,7 @@ public sealed class DataListDataEditor : IDataEditor
internal const string DataEditorAlias = Constants.Internals.DataEditorAliasPrefix + "DataList";
internal const string DataEditorName = Constants.Internals.DataEditorNamePrefix + "Data List";
internal const string DataEditorViewPath = Constants.Internals.EditorsPathRoot + "_empty.html";
- internal const string DataEditorIcon = "icon-bulleted-list";
+ internal const string DataEditorIcon = "icon-fa fa-list-ul";
private readonly ConfigurationEditorUtility _utility;
diff --git a/src/Umbraco.Community.Contentment/DataEditors/DataList/DataSources/SqlDataListSource.cs b/src/Umbraco.Community.Contentment/DataEditors/DataList/DataSources/SqlDataListSource.cs
index 248b4d1d..9573bed3 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/DataList/DataSources/SqlDataListSource.cs
+++ b/src/Umbraco.Community.Contentment/DataEditors/DataList/DataSources/SqlDataListSource.cs
@@ -74,7 +74,7 @@ public SqlDataListSource()
{
Key = "connectionString",
Name = "Connection string",
- Description = "Enter the connection string.",
+ Description = "Select the connection string.",
View = IOHelper.ResolveUrl(DropdownListDataListEditor.DataEditorViewPath),
Config = new Dictionary
{
diff --git a/src/Umbraco.Community.Contentment/DataEditors/IconPicker/IconPickerDataEditor.cs b/src/Umbraco.Community.Contentment/DataEditors/IconPicker/IconPickerDataEditor.cs
index fb4472ed..383252a7 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/IconPicker/IconPickerDataEditor.cs
+++ b/src/Umbraco.Community.Contentment/DataEditors/IconPicker/IconPickerDataEditor.cs
@@ -21,7 +21,7 @@ public sealed class IconPickerDataEditor : DataEditor
internal const string DataEditorAlias = Constants.Internals.DataEditorAliasPrefix + "IconPicker";
internal const string DataEditorName = Constants.Internals.DataEditorNamePrefix + "Icon Picker";
internal const string DataEditorViewPath = Constants.Internals.EditorsPathRoot + "icon-picker.html";
- internal const string DataEditorIcon = "icon-circle-dotted";
+ internal const string DataEditorIcon = "icon-fa fa-circle-o";
public IconPickerDataEditor(ILogger logger)
: base(logger)
diff --git a/src/Umbraco.Community.Contentment/DataEditors/Notes/NotesConfigurationEditor.cs b/src/Umbraco.Community.Contentment/DataEditors/Notes/NotesConfigurationEditor.cs
index 71e99774..2a366eb3 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/Notes/NotesConfigurationEditor.cs
+++ b/src/Umbraco.Community.Contentment/DataEditors/Notes/NotesConfigurationEditor.cs
@@ -23,33 +23,7 @@ public NotesConfigurationEditor()
IOHelper.ResolveUrl("~/umbraco/views/propertyeditors/rte/rte.html"),
new Dictionary
{
- { "editor", new
- {
- maxImageSize = 500,
- mode = "classic",
- stylesheets = false,
- toolbar = new[]
- {
- "ace",
- "undo",
- "redo",
- "cut",
- "styleselect",
- "removeformat",
- "bold",
- "italic",
- "alignleft",
- "aligncenter",
- "alignright",
- "bullist",
- "numlist",
- "link",
- "umbmediapicker",
- "umbmacro",
- "umbembeddialog"
- },
- }
- }
+ { "editor", Constants.Conventions.DefaultConfiguration.RichTextEditor }
});
Fields.Add(new HideLabelConfigurationField());
diff --git a/src/Umbraco.Community.Contentment/DataEditors/Notes/NotesDataEditor.cs b/src/Umbraco.Community.Contentment/DataEditors/Notes/NotesDataEditor.cs
index cf1d011f..2bf191ed 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/Notes/NotesDataEditor.cs
+++ b/src/Umbraco.Community.Contentment/DataEditors/Notes/NotesDataEditor.cs
@@ -14,7 +14,7 @@ public sealed class NotesDataEditor : IDataEditor
internal const string DataEditorAlias = Constants.Internals.DataEditorAliasPrefix + "Notes";
internal const string DataEditorName = Constants.Internals.DataEditorNamePrefix + "Notes";
internal const string DataEditorViewPath = Constants.Internals.EditorsPathRoot + "notes.html";
- internal const string DataEditorIcon = "icon-readonly";
+ internal const string DataEditorIcon = "icon-fa fa-sticky-note-o";
public string Alias => DataEditorAlias;
diff --git a/src/Umbraco.Community.Contentment/DataEditors/RadioButtonList/RadioButtonListDataListEditor.cs b/src/Umbraco.Community.Contentment/DataEditors/RadioButtonList/RadioButtonListDataListEditor.cs
index 716a9d97..103d7478 100644
--- a/src/Umbraco.Community.Contentment/DataEditors/RadioButtonList/RadioButtonListDataListEditor.cs
+++ b/src/Umbraco.Community.Contentment/DataEditors/RadioButtonList/RadioButtonListDataListEditor.cs
@@ -14,7 +14,7 @@ public sealed class RadioButtonListDataListEditor : IDataListEditor
public string Name => "Radio Button List";
- public string Description => "Select a single value from a list of radio buttons";
+ public string Description => "Select a single value from a list of radio buttons.";
public string Icon => "icon-target";
diff --git a/src/Umbraco.Community.Contentment/Migrations/Install/RegisterUmbracoPackageEntry.cs b/src/Umbraco.Community.Contentment/Migrations/Install/RegisterUmbracoPackageEntry.cs
index 9dcce5d2..3930120e 100644
--- a/src/Umbraco.Community.Contentment/Migrations/Install/RegisterUmbracoPackageEntry.cs
+++ b/src/Umbraco.Community.Contentment/Migrations/Install/RegisterUmbracoPackageEntry.cs
@@ -39,7 +39,7 @@ public override void Migrate()
License = Constants.Package.License,
LicenseUrl = Constants.Package.LicenseUrl,
UmbracoVersion = Constants.Package.MinimumSupportedUmbracoVersion,
- Version = ContentmentVersion.Version.ToString(),
+ Version = Configuration.ContentmentVersion.Version.ToString(),
Readme = "",
});
}
diff --git a/src/Umbraco.Community.Contentment/Trees/ContentmentTreeController.cs b/src/Umbraco.Community.Contentment/Trees/ContentmentTreeController.cs
index e5555e02..ae472c08 100644
--- a/src/Umbraco.Community.Contentment/Trees/ContentmentTreeController.cs
+++ b/src/Umbraco.Community.Contentment/Trees/ContentmentTreeController.cs
@@ -27,7 +27,7 @@ protected override TreeNode CreateRootNode(FormDataCollection queryStrings)
{
var root = base.CreateRootNode(queryStrings);
- root.Icon = "icon-fa fa-dot-circle-o";
+ root.Icon = "icon-fa fa-cube";
root.HasChildren = false;
root.RoutePath = $"{SectionAlias}/{TreeAlias}/index";
root.MenuUrl = null;
diff --git a/src/Umbraco.Community.Contentment/Umbraco.Community.Contentment.csproj b/src/Umbraco.Community.Contentment/Umbraco.Community.Contentment.csproj
index 733ee1ce..69af9962 100644
--- a/src/Umbraco.Community.Contentment/Umbraco.Community.Contentment.csproj
+++ b/src/Umbraco.Community.Contentment/Umbraco.Community.Contentment.csproj
@@ -294,7 +294,7 @@
-
+
@@ -312,7 +312,6 @@
-
diff --git a/src/Umbraco.Community.Contentment/Web/UI/App_Plugins/Contentment/backoffice/contentment/index.html b/src/Umbraco.Community.Contentment/Web/UI/App_Plugins/Contentment/backoffice/contentment/index.html
index 927bc873..84fb699b 100644
--- a/src/Umbraco.Community.Contentment/Web/UI/App_Plugins/Contentment/backoffice/contentment/index.html
+++ b/src/Umbraco.Community.Contentment/Web/UI/App_Plugins/Contentment/backoffice/contentment/index.html
@@ -10,7 +10,7 @@