Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with currency comparisons #54

Open
frosklis opened this issue Mar 4, 2021 · 1 comment
Open

Deal with currency comparisons #54

frosklis opened this issue Mar 4, 2021 · 1 comment
Assignees
@frosklis
Labels
bug Something isn't working

Comments

@frosklis
Copy link
Collaborator

frosklis commented Mar 4, 2021 •
edited
Loading

How to deal with things like amount < 1000 EUR when the currency is not EUR?

Looks like it should return always false, but then not(amount < 1000 EUR) should evaluate to false as well.

And when combined with things like any(amount < 1000 EUR), the postings should not count.

To panic is not always right.
@frosklis frosklis added the bug Something isn't working label Mar 4, 2021
@frosklis frosklis self-assigned this Mar 4, 2021
@frosklis
Copy link
Collaborator Author

The good solution is to convert from one currency to another and only panic if that is not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frosklis frosklis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frosklis