Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Invalid prop" error #13125

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix "Invalid prop" error #13125

wants to merge 1 commit into from

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 27, 2025 •
edited
Loading

Summary

Fixes "Invalid prop: custom validator check failed for prop 'value' error by removing what appears to be, as best as I can say, the obsolete 'channels' object property that is not passed into and neither used in the component.

References

Fixes #13058

Reviewer guidance

Note there is The computed property "PageNames" is already defined in data warning in the browser console - will fix in another PR.

QA

  • Go to Coach -> Lesson -> Manage resources -> rewrite /lessons to /lessonstemp URL and in the "Manage lesson resources", click on the Search button (make sure you see the new experience)

Screenshot from 2025-02-27 19-26-38

  • Check that there is no "Invalid prop" error in the browser console
  • There should be no regressions in the side panel

Code

  • 'channels' is really not needed anywhere?

@MisRob
Fix validator failure
696a31a 
by removing the obsolete 'channels' object property
that is not passed into and neither used in the component.
@github-actions GitHub Actions
Copy link
Contributor

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0a2.dev0_git.2.gcff09adc.pex
Windows Installer (EXE) kolibri-0.18.0a2.dev0+git.2.gcff09adc-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0a2.dev0+git.2.gcff09adc-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0a2.dev0+git.2.gcff09adc.dmg
Android Package (APK) kolibri-0.18.0a2.dev0+git.2.gcff09adc-0.1.4-debug.apk
Raspberry Pi Image kolibri-pi-image-0.18.0a2.dev0+git.2.gcff09adc.zip
TAR file kolibri-0.18.0a2.dev0+git.2.gcff09adc.tar.gz
WHL file kolibri-0.18.0a2.dev0+git.2.gcff09adc-py2.py3-none-any.whl

@MisRob MisRob added the TODO: needs review Waiting for review label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis Awaiting requested review from nucleogenesis

@marcellamaki marcellamaki Awaiting requested review from marcellamaki

@AlexVelezLl AlexVelezLl Awaiting requested review from AlexVelezLl

@AllanOXDi AllanOXDi Awaiting requested review from AllanOXDi

@radinamatic radinamatic Awaiting requested review from radinamatic

@pcenov pcenov Awaiting requested review from pcenov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
TODO: needs review Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid Prop in Search Filters
1 participant
@MisRob