Add unstarted quiz string to quiz reports for learners who haven't started a quiz #13112
Conversation
…who have not yet started a quiz
Build Artifacts
|
|
Flagging @radinamatic @pcenov because I believe this will need a QA review, thank you! |
There was a problem hiding this comment.
Hi @LianaHarris360! Everything looks good to me code wise. Just left a thought.
| @@ -565,6 +565,10 @@ export const coreStrings = createTranslator('CommonCoreStrings', { | |||
| message: 'Important: please remember this account information. Write it down if needed.', | |||
| context: 'Helper/information text to remind user to take note of their account information.', | |||
| }, | |||
| quizNotStartedText: { | |||
| message: 'Quiz not started', | |||
There was a problem hiding this comment.
Just wondering if this can sit commonCoach Or searchAndFilter?
There was a problem hiding this comment.
It could perhaps go in searchAndFilter. My first thought was to put this string in commonCoach, but since it’s primary usage would be the QuizReport in kolibri-common, I figured it would be best to place it in a more general place. I guess it’s not super clear to me where this string should go since it’s not within the release feature. Should I move this string? @marcellamaki
There was a problem hiding this comment.
Thank you @LianaHarris360. Code looks good to me - the string placement in question makes sense to me, but let's wait for the confirm from @marcellamaki since I may a bit outdated around how we plan strings for features.
Summary
This pull request updates the coach’s display of quiz reports with the message: “Quiz not started” for learners that have not started a quiz to properly indicate that the quiz has not been started.
Before:
After:
References
Fixes #13057
Reviewer guidance