Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device > Facilities - The name of the removed facility is not shown in the snackbar confirmation message #13048

Closed
pcenov opened this issue Feb 4, 2025 · 1 comment · Fixed by #13050
Closed

Device > Facilities - The name of the removed facility is not shown in the snackbar confirmation message #13048

pcenov opened this issue Feb 4, 2025 · 1 comment · Fixed by #13050
Assignees
@nucleogenesis
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) bug Behavior is wrong or broken DEV: frontend P1 - important Priority: High impact on UX
Milestone
Kolibri 0.18: Gen...

Comments

@pcenov
Copy link
Member

pcenov commented Feb 4, 2025

Observed behavior

The name of the removed facility is not shown in the snackbar confirmation message:

removed.facility.mp4

Expected behavior

The facility name should be displayed in the snackbar message. Perhaps the text of the confirmation message should be improved as well as currently it is just "Removed 'Facility name' from this device" which sounds a bit robotic, no offense to the robots meant :)

Steps to reproduce the issue

  1. Install the official Kolibri 0.17.5 build or any of the current 0.18 builds
  2. Go to Device > Facilities and remove a facility
  3. Observe the text of the snackbar message

Usage Details

Kolibri 0.17.5 and 0.18
All browsers and OSs.
@pcenov
Copy link
Member Author

pcenov commented Feb 4, 2025

@radinamatic

@pcenov pcenov mentioned this issue Feb 4, 2025
Merged
@radinamatic radinamatic added bug Behavior is wrong or broken P1 - important Priority: High impact on UX APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend labels Feb 4, 2025
@nucleogenesis nucleogenesis self-assigned this Feb 4, 2025
@nucleogenesis nucleogenesis mentioned this issue Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nucleogenesis nucleogenesis

Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) bug Behavior is wrong or broken DEV: frontend P1 - important Priority: High impact on UX
Projects
None yet
Milestone
Kolibri 0.18: General maintenance
Development

Successfully merging a pull request may close this issue.

Fix missing facility_name in facility removal notification nucleogenesis/kolibri
3 participants
@radinamatic @nucleogenesis @pcenov