Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in common CategorySearchModal #13033

Closed
marcellamaki opened this issue Jan 28, 2025 — with Slack · 1 comment
Closed

Fix bugs in common CategorySearchModal #13033

marcellamaki opened this issue Jan 28, 2025 — with Slack · 1 comment
Assignees
@AllanOXDi
Labels
bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression
Milestone
Kolibri 0.18: Coa...

Comments

@marcellamaki Slack
Copy link
Member

marcellamaki commented Jan 28, 2025 •
edited
Loading

We've seen a couple of bugs appear in the refactored/abstracted CategorySearchModal.

First, reported by Alex in slack:

While working with the SearchFiltersPanel component, I found this suspicious condition to render the categories selector windowIsLarge && currentCategory :

https://github.com/learningequality/kolibri/blob/5bf546e7e63bac87df02242ca25be022dfe5af98/packages/kolibri-common/components/SearchFiltersPanel/index.vue#L146|https://github.com/learningequality/kolibri/blob/5bf546e7e63bac87df02242ca25be022d[…]packages/kolibri-common/components/SearchFiltersPanel/index.vue , but I didnt find any other condition that renders the categories selector when !windowIsLarge , so in learn if we open a category in the filter, we just see an empty page. Is this a known issue?

Slack Message

And later spotted by Peter in another PR.

The CategorySearchModal should work properly in all large/pop up modal views (i.e. windowIsLarge in Learn), in side panel view in Learn, in the side panel in coach across all screen sizes.
@marcellamaki marcellamaki added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression labels Jan 28, 2025 — with Slack
@adiitxa adiitxa mentioned this issue Feb 6, 2025
Closed
@AllanOXDi AllanOXDi mentioned this issue Feb 6, 2025
Merged
@AllanOXDi
Copy link
Member

fixed in #13056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AllanOXDi AllanOXDi

Labels
bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression
Projects
None yet
Milestone
Kolibri 0.18: Coach Resource Discovery
Development

No branches or pull requests
2 participants
@marcellamaki @AllanOXDi