Quiz creation: Show correct answers for questions #13038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
nucleogenesis
force-pushed
the
13025-correct-answers-missing-in-coach
branch
from
985f1ce to
105626a
Compare
Build Artifacts
|
my inclination is yes - anywhere in coach the correct answer should be indicated |
marcellamaki
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Hey @nucleogenesis - testing this out manually it doesn't seem to resolve the problem. I'm not sure if there's some underlying bug with the showCorrectAnswer prop or with the perseus renderer, but I think this quick fix may unfortunately have been too good to be true :(
marcellamaki
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Puts the
showCorrectAnswers=trueprop onto the ContentRenderer in QuestiosnAccordion.I also applied it in ReplaceQuestions, although that is liable to be removed.
Also, in the QuestionListPreview it is explicitly set to
false(which I did, but I don't recall why) - but should I also flip that one?References
Fixes #13025
Reviewer guidance
Do you see correct answers in Quiz Creation after adding questions?