Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage lesson resources > Search - No indication that there are no imported resources on the device #13021

Closed
pcenov opened this issue Jan 22, 2025 · 2 comments · Fixed by #13041
Closed

Manage lesson resources > Search - No indication that there are no imported resources on the device #13021

pcenov opened this issue Jan 22, 2025 · 2 comments · Fixed by #13041
Assignees
@marcellamaki
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression TAG: user strings Application text that gets translated
Milestone
Kolibri 0.18: Gen...

Comments

@pcenov
Copy link
Member

pcenov commented Jan 22, 2025

Observed behavior

This is a follow-up to #13008 - We probably need to indicate in a better way within the search panel that there are no channels to import from when there aren't any as currently this is what I see in that case:

2025-01-20_14-45-55

Expected behavior

To be further discussed.

Steps to reproduce the issue

  1. Install the latest build from Integrate search resource selection #13008
  2. Go to Coach > Lessons > Lesson > Manage resources
  3. Observe that there's only the "Select from channels" label

Usage Details

Windows 11, Ubuntu 22 - Chrome
@pcenov
Copy link
Member Author

pcenov commented Jan 22, 2025

@radinamatic

@pcenov pcenov mentioned this issue Jan 22, 2025
Merged
@radinamatic radinamatic added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression TAG: user strings Application text that gets translated APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jan 24, 2025
@radinamatic
Copy link
Member

We have the There are no channels string on Crowdin, but I'd suggest something a bit more explanatory, for example:

There are no resources available. Please contact your administrator to import channels on this device.

@marcellamaki marcellamaki mentioned this issue Jan 29, 2025
Merged
@marcellamaki marcellamaki self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcellamaki marcellamaki

Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression TAG: user strings Application text that gets translated
Projects
None yet
Milestone
Kolibri 0.18: General maintenance
Development

Successfully merging a pull request may close this issue.

Add a placeholder string when no resources are available/no channels on devices marcellamaki/kolibri
3 participants
@radinamatic @marcellamaki @pcenov