Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Attempts" column for non-practice quiz resources #13011

Closed
marcellamaki opened this issue Jan 16, 2025 — with Slack · 5 comments · Fixed by #13046
Closed

Remove the "Attempts" column for non-practice quiz resources #13011

marcellamaki opened this issue Jan 16, 2025 — with Slack · 5 comments · Fixed by #13046
Assignees

Comments

Copy link
Member

marcellamaki commented Jan 16, 2025

The "attempts" column was inadvertently added to all resources in the resource report for learners, when it should only be visible (currently) for practice quizzes. This should only be added for exercises after we complete: #9851

Slack Message

Exercise:

Image

Other resource:

Image

@marcellamaki marcellamaki added this to the Kolibri 0.18: General maintenance milestone Jan 16, 2025 — with Slack
@rtibbles
Copy link
Member

It seems like the original conditionality that should have gated this is still in play: https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/coach/assets/src/views/common/tables/ReportsLearnersTable.vue#L10

So the data table itself is now having tries added to it in non-practice quiz contexts.

@rtibbles
Copy link
Member

This will require some digging through the vuex state to determine how and why this is happening - it appears that it is also happening for non-exercise resource types to - so it is being set to 0 rather than being undefined.

@rtibbles rtibbles changed the title Remove the "Attempts" column for exercises Remove the "Attempts" column for non-practice quiz resources Jan 16, 2025
@rtibbles
Copy link
Member

It may also just be simpler than trying to mess with the passed in entries to instead just add a prop that controls the display of the attempts column to the ReportsLearnerTable and conditionalize that on whether it is a practice quiz or not.

@you-think-you-know-me
Copy link

Hey @rtibbles , I would love to work on this issue. Please assign this to me.

@AlexVelezLl
Copy link
Member

Hey @you-think-you-know-me! hanks for your interest in contributing to solving this issue! 👐. Unfortunately, this issue is not intended for Open Source contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants