-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visual testing]: Add visual tests for KBreadcrumbs #924
Comments
@AlexVelezLl May i work on this issue , assign it to me please. |
Hey @RONAK-AI647! Sure thing! I will assign this to you. Please let us know if you have any question 👐. |
@AlexVelezLl I have some questions : firstly I am facing issue in setting the local environment. I went through the visual testing guide and
|
Hi @RONAK-AI647, thanks for letting us know. We really don't recommend Windows for development and unfortunately don't have a way to try it out ourselves. However many contributors have successfully set up their development environment on Windows using WSL or a Linux image in VirtualBox.Y ou may need to experiment some more. In case it's not possible, feel free to message us and find another issue instead. |
Hi @RONAK-AI647, I'd recommend using virtualbox as well, However as a workaround for this issue you can try adding the PERCY_TOKEN as a PATH variable. I have linked a video for your reference. |
@adibmbrk Thank You , virtualbox is great recommendation . I myself use virtualbox , there was some error with the version control whose work is on progress. Thank You, the link helped. |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Context
We recently introduced a new visual testing system in KDS to prevent visual regressions and ensure UI consistency, and we want to start populating our KDS components with visual tests.
If you are not familiar yet with our visual testing system. Please refer to our Visual Testing Guide. You can also check the existing tests for KButton as an example.
Additionally, see the KBreadcrumbs documentation for reference.
Desired behavior
KBreadcrumbs
should have visual tests to cover at least these snapshots:Note
Since we currently dont have a test file for KBreadcrumbs. Please move the current
KBreadcrumbs.vue
file to be a folderKBreadcrumbs/index.vue
and create the test file inKBreadcrumbs/__tests__/KBreadcrumbs.spec.js
Acceptance criteria
KBreadcrumbs
.The text was updated successfully, but these errors were encountered: