-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KListWithOverflow]: Add unit tests #833
Comments
Hi @AlexVelezLl , I would like to work on this issue. Please assign to me. |
Hey @yeshwanth235 thank you for your interest in handling this issue, I can assign it to you. Please let us know if you have any questions! :) |
Hey @AlexVelezLl , I would like to work on this issue. If no one is working on this, please assign this to me. |
Hey @you-think-you-know-me, thanks for your interest in contributing to LE! As we haven't had any activity from the currently assigned contributor in two months, I will reassign this issue to you :). Please let us know if you have any questions! |
@AlexVelezLl I have raised the PR. Please review it. |
Thanks @you-think-you-know-me! I will take a look at it this week :) |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Product
KDS.
Desired behavior
We should add unit tests to KListWithOverflow, since it has some complicated calculations and needs to be protected from regressions. So we need to test at least the following things:
more
slot if the list items fits in the available space.more
slot if there are overflowed items.overflowItems
array passed to themore
slot.Current behavior
We currently dont have unit tests for KListWithOverflow.
The text was updated successfully, but these errors were encountered: