Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 404 not found page #26

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add 404 not found page #26

wants to merge 2 commits into from

Conversation

bipulthapa
Copy link

@bipulthapa bipulthapa commented May 1, 2020 •
edited by pratishshr
Loading

  • Add 404 not found page

Closes #5

@bipulthapa bipulthapa requested a review from pratishshr May 1, 2020 11:28
@bipulthapa bipulthapa self-assigned this May 1, 2020
@bipulthapa bipulthapa requested a review from anishmanandhar May 1, 2020 11:29
pratishshr
pratishshr suggested changes May 5, 2020
View reviewed changes
src/components/NotFound.js Outdated Show resolved Hide resolved
src/components/home/HomeRouter.js Outdated Show resolved Hide resolved
@bipulthapa bipulthapa requested a review from pratishshr May 8, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishmanandhar anishmanandhar Awaiting requested review from anishmanandhar

@pratishshr pratishshr Awaiting requested review from pratishshr

At least 1 approving review is required to merge this pull request.

Assignees

@bipulthapa bipulthapa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 404 not found page
2 participants
@bipulthapa @pratishshr