Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying install path #15

Open
TheCycoONE opened this issue Dec 9, 2020 · 6 comments
Open

Allow specifying install path #15

TheCycoONE opened this issue Dec 9, 2020 · 6 comments

Comments

@TheCycoONE
Copy link

TheCycoONE commented Dec 9, 2020

I would like to use the resulting lua libraries in a CMake project. Right now this appears to install in whatever the current working directory is, which cannot be set for a uses action. It's actually ending up in the checkout path for my repo which is causing other issues for my file formatting scans.

It would be nice to either provide the directory e.g. with: installPath=${MY_PATH} or to expose the install path somehow to the parent action.

@TheCycoONE
Copy link
Author

I attempted to work around by putting these actions before - uses: actions/checkout@v2
When I did that, lua and luarocks were not in the path at all.

@alerque
Copy link

alerque commented Dec 13, 2020

Just use a - run: step after running this and use shell commands to move or copy the files you want wherever you want them. You'll have to set any related path variables yourself, but you can put stuff wherever you like.

@daurnimator
Copy link

I too would like this as a feature: as-is, luacheck . in my repo picks up the entire .install directory.

@alerque
Copy link

alerque commented Jan 28, 2021

Hence why all my projects have .luacheckrc files with exclude_files = { ".install" } (along with a few other CI induced ignores).

Come to think of it, the default path should probably be somewhere in the runner's home directory and not in the project Git workspace at all.

@im-mortal
Copy link

I feel like the default should really be a folder outside of github.workspace, along with an ability to specify install path.
After performing leafo/gh-actions-lua and leafo/gh-actions-luarocks actions, running luarocks write_rockspec in a checked out repository results in a rockspec file that includes all the lua files from auxiliary folders aforementioned actions rely on (most notably .lua and .luarocks), which is clearly unintended behavior.
https://github.com/leafo/gh-actions-luarocks could use these improvements, too.

@Miqueas
Copy link

Miqueas commented Nov 11, 2021

Yeah, I think will be great allow to set the installation path

alex-courtis pushed a commit to nvim-tree/nvim-web-devicons that referenced this issue Mar 21, 2023
* ci: install lua, luarocks, luacheck and neovim

* chore: add gitignore

This is necessary due to leafo/gh-actions-lua installing lua and
luarocks in working directory (see 1) which causes
peter-evans/create-pull-request to pick them up as wanted changes.

1) leafo/gh-actions-lua#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants