Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need test coverage of all functions #8

Open
drobnyjt opened this issue May 11, 2020 · 5 comments
Open

Need test coverage of all functions #8

drobnyjt opened this issue May 11, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@drobnyjt
Copy link
Collaborator

No description provided.

@drobnyjt drobnyjt added the enhancement New feature or request label May 12, 2020
@drobnyjt drobnyjt self-assigned this May 12, 2020
@drobnyjt
Copy link
Collaborator Author

An essential step here would be to separate large, currently integrated functions into testable units - examples being the different forms of electronic stopping, or the different pieces thereof (mean ionization energy, etc.)

@drobnyjt
Copy link
Collaborator Author

Added integrated test for momentum conservation during binary collision. Setting this up caught a bug in the MAGIC implementation of the ZBL potential - the screening length used was incorrect, leading to the generation of NaNs. It also highlighted the need to separate a handful of lines of code in main.rs out into functions - the most obvious example being updating the recoil energy - but, the momentum conservation test works, for all energies and physics options tested, momentum is conserved to within an epsilon of 1E-12.

@drobnyjt
Copy link
Collaborator Author

Test coverage now includes rootfinder (both Newton and CPR (if built with --features cpr_rootfinder)). I need to write a polynomial rootfinder test.

Additionally, tests have been added for all the forms of the scattering integral - Gauss-Mehler, Gauss-Legendre, Mendenhall-Weller, and MAGIC.

@drobnyjt
Copy link
Collaborator Author

drobnyjt commented Mar 3, 2021

Mesh0D and Mesh2D are adequately tested, but units tests need to be written for Mesh1D.

@drobnyjt
Copy link
Collaborator Author

drobnyjt commented Mar 7, 2021

Added tests for the new planar surface binding potential and for the Sphere geometry.

@drobnyjt drobnyjt added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant