Apparent unmatched double quote in Clojure-style output

[rebcabin]

This command (compiling tests/expr7.py)

("/Users/brian/Documents/GitHub/lpython/src/bin/lpython"
 "-I/Users/brian/Documents/GitHub/lpython/src/runtime/ltypes/ltypes.py"
 "--show-asr"
 "--no-color"
 "--with-intrinsic-mods"
 "/Users/brian/Documents/GitHub/lpython/tests/expr7.py")

produces the following sub-form, which has (apparently) an unmatched double-quote in it, right after the ! character:

(StringConstant " !"#$%&\'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~" (Character 1 97 () []))

it probably should be

(StringConstant " !\"#$%&\'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~" (Character 1 97 () []))

with the double-quote escaped.

HOWEVER

This issue, #1505, corrected or not, raises Issue #1420 to BLOCKER status, because the colon embedded in the string constant gets caught by my ad-hoc, regex-based keyword patcher. I don't know any easy way to match foobar: but not " !\"#$%&...789:;<=...". My ad-hoc, regex-based keyword patcher correctly changes foobar: to :foobar, but incorrectly reorders the string constant from

" !\"#$%&...789:;<=..."

to

" :!\"#$%&...789;<=...".

With this issue, #1505, UN-corrected, my ad-hoc, regex-based keyword patch changes

" !"#$%&...789:;<=..."

to

" :!"#$%&...789:;<=..."

which has an illegal Clojure reader macro, #$%&... in it.

Suffice it to say that Issue #1420 and this issue, #1505, are now both BLOCKERs.

SUPPLEMENTARY SCREEN SHOT

[Ahmedkhalifa1999]

Is this issue, along with #1420 and #1498 still open?
I would like to work on fixing the output (colons and unmatched quote), but will need some guidance on what needs to be done to make it canonical Clojure.

[rebcabin]

I'm working on various Clojure-tools for asr. #1420 and this issue are the big ones, for now. It would be nice if .true. and .false. were true and false, respecively, but that's not necessary.

An optional verbose mode, in which ASR terms became Clojure maps, would be grand, too. Example:

        '{:head Variable
          :parent-symtab-id 2
          :name x
          :intent Local
          :symbolic-value '{:head IntegerConstant
           :value 5,  :ttype {:base-type 'Integer :kind-bytes 4 :dims []}}
...

instead of

        '(Variable        ; head
          2               ; parent-symtab
          x               ; nym
          Local           ; intent
          (IntegerConstant
           5 (Integer 4 [])) ; symbolic-value
...

[rebcabin]

The big picture is to validate and generate ASR terms via clojure.spec. This amounts to a type system for ASR. It's a big, long-term job. See https://github.com/rebcabin/asr-tester/blob/main/src/asr/specs.clj and surrounding code for examples, especially https://github.com/rebcabin/asr-tester/blob/main/test/asr/core_test.clj.

I am seeking contributors to those projects :)

My code is currently in a broken state because ASR changed more quickly than I could keep up. I am contemplating an alternative https://github.com/rebcabin/masr , to replace ASDL with clojure spacs.

[Ahmedkhalifa1999]

I have an idea, though my information will need verification from someone who knows the codebase better than me.
What if we added an optional argument that formatted the output tree in Clojure-style (at least temporarily)?
The rationale from my side is that this will allow more freedom with the output (no need to worry about other uses of the ASR output) and also keep the output working if anyone else is relying on it for a different purpose.
If this is a valid idea, I can start working on it with a little guidance with the code base and some significant guidance about what is and is not allowed in Clojure.

I would be very interested to contribute to those projects in my free time, but I will need to learn Clojure first, since it will be my first encounter with it or Lisp :)

[rebcabin]

I think that's an excellent idea! We need not derange the current code base, simply implement something like --show-canonical-clojure and party in our own back yard. If you can begin by cracking into how --show-asr works, i can provide some guidance on the C++ side and a lot of guidance on the clojure side.

[rebcabin]

Clojure has a bit of a learning curve, but it's very pleasant once you get over it. Here is a tiny, recent project from me on a tiny type-system (one day, far future, for ASR). You might find it amusing: https://github.com/rebcabin/concurrent-kittens

I have dozens more clojure projects. I put clojure into production at Amazon. It's grand and glorious.

[Ahmedkhalifa1999]

That's great. I will start getting to know how --show-asr works, look into the basics of Clojure and come back with questions.

[rebcabin]

https://clojuredocs.org/ is invaluable

https://www.braveclojure.com/ is priceless, right from the start

[ubaidsk]

We need not derange the current code base, simply implement something like --show-canonical-clojure and party in our own back yard

We currently have

• --show-asr --tree for tree-like printing of ASR.
• --show-asr --json for ASR json format

I think similarly we can have --show-asr --clojure for ASR Clojure format.

[rebcabin]

If you write out Clojure maps (hashmaps) like {:head Variable, :parent-symtab-id 2, ,,,} then it will be very easy for me to convert them into Clojure defrecords, to subject them to Clojure defprotocol and clojure.specs. So I guess I will call that a requirement for a verbose Clojure mode.