Fix cmake flags #534
Open
Fix cmake flags #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to append to the parent scope's variable, but we're using the current scope to do so
Fixes warning "declaration shadows a local variable"
avoids "declared but not used" warning on release builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #533.
The
lcm_add_c_flagsandlcm_add_cxx_flagshad a bug in them. Their goal was to append to variable in the parent scope, but they were using a variable in their local scope to do so. My fix was to add an additionalsetcommand in f1e0e29 which also appended to the local variable so it could be used as the base value for the parent scope variable in the next iteration of the loop.The rest of the commits are fixing warnings that are now successfully getting enabled. Fixing the
stringop-truncationwarnings seemed like more of a hassle than it was worth so I just disabled that one. The other commits are fixing unused, unitialized, or shadowed variables.