Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Mana and h (highlight) tags in locales #18

Open
ed-ev opened this issue Sep 30, 2024 · 0 comments
Open

Generalize Mana and h (highlight) tags in locales #18

ed-ev opened this issue Sep 30, 2024 · 0 comments

Comments

@ed-ev
Copy link
Collaborator

ed-ev commented Sep 30, 2024

Current:

// <Mana1 />, <ManaP />, etc
Mana1: <CardManaWidget mana="1" />

// <hg>...</hg>, <ha>...</ha>, etc
hg: <Highlight color="g">{}</Highlight>

Preferred:

// <Mana mana='1' />
Mana: <CardManaWidget mana="" />
// <h color='g'>...</h>
h: <Highlight color="">{}</Highlight>

Not working because React component props override is only available for basic html tags
i18next/react-i18next#1802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant