Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster names are not reset for each independent clustering #25

Open
barrybecker4 opened this issue Feb 13, 2019 · 0 comments
Open

cluster names are not reset for each independent clustering #25

barrybecker4 opened this issue Feb 13, 2019 · 0 comments

Comments

@barrybecker4
Copy link

I don't think globalIndex should be static in ClusterPair.
It means that it just keeps getting incremented for every clustering that you do in a single instantiation of a JVM. This will lead to many problems such as:

  • You will eventually get really large numbers in the cluster names if you run enough clusterings. I guess its not likely to overflow since its a long though.
  • Unit tests are very hard to write because the results from one test are dependent on those that run before it. This should not be the case.
  • Different results when running a clustering on the same data multiple times.

Instead the cluster indexes should only be global for a single clustering, not across all clusterings.
I will try to make a PR.

barrybecker4 pushed a commit to esi-mineset/hierarchical-clustering-java that referenced this issue Feb 13, 2019
There were mixed tabs and spaces. Made it use spaces instead of tabs as that seems to be the convention in most files.
barrybecker4 pushed a commit to esi-mineset/hierarchical-clustering-java that referenced this issue Feb 13, 2019
Replace the static global counter, with an index maintained by the HierarchyBuilder.
lbehnke added a commit that referenced this issue Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant