Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchBar does not support Keyboard Events #718

Open
Muhammed-Moinuddin opened this issue Aug 16, 2024 · 0 comments · May be fixed by #719
Open

SearchBar does not support Keyboard Events #718

Muhammed-Moinuddin opened this issue Aug 16, 2024 · 0 comments · May be fixed by #719
Assignees
@Muhammed-Moinuddin
Labels
kind/enhancement Improvement in current feature

Comments

@Muhammed-Moinuddin
Copy link
Contributor

Muhammed-Moinuddin commented Aug 16, 2024 •
edited
Loading

Current Behavior

Currectly custom SearchBar does not support Keyboard Events.
I found out this issue while working with Terminal Logs.

Desired Behavior

It should support keyboard events

Implementation

Adding OnKeyDown property in sistent custom Searchbar as well as on StyledSearchBar.

In below video first I used sistent searchbar (which was not handling pressing keys like Enter). Then I implemented searchbar I created and it worked fine.

2024-08-16.10-27-51.mp4

Acceptance Tests

Mockups

Contributor Guide
@Muhammed-Moinuddin Muhammed-Moinuddin added the kind/enhancement Improvement in current feature label Aug 16, 2024
@Muhammed-Moinuddin Muhammed-Moinuddin self-assigned this Aug 16, 2024
@Muhammed-Moinuddin Muhammed-Moinuddin linked a pull request Aug 16, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Muhammed-Moinuddin Muhammed-Moinuddin

Labels
kind/enhancement Improvement in current feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added OnKeyDown functionality to both custom Searchbars Muhammed-Moinuddin/sistent
1 participant
@Muhammed-Moinuddin