Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate separate markdown renderers #624

Open
dragon-slayer875 opened this issue May 20, 2024 · 4 comments · May be fixed by #715
Open

Consolidate separate markdown renderers #624

dragon-slayer875 opened this issue May 20, 2024 · 4 comments · May be fixed by #715
Assignees
Labels
issue/willfix This issue will be worked on

Comments

@dragon-slayer875
Copy link
Contributor

dragon-slayer875 commented May 20, 2024

Current Behavior

Currently, we use two Markdown renderers:

  • RenderMarkdown
  • RenderMarkdownTooltip

This was done at the time to avoid a change in functionality without reviewer availability.
But it has been reviewed since then, and now it is desired to be consolidated.

Expected Behavior

They can be consolidated into one by passing props instead, to make a single component.

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v

Contributor Guides and Resources

@dragon-slayer875 dragon-slayer875 added the issue/willfix This issue will be worked on label May 20, 2024
@dragon-slayer875
Copy link
Contributor Author

// @sudhanshutech

@senthil-athiban
Copy link
Contributor

@dragon-slayer875 , I would like to work on these issue.

@dragon-slayer875
Copy link
Contributor Author

@senthil-athiban any updates here?

@senthil-athiban
Copy link
Contributor

senthil-athiban commented Aug 12, 2024

sorry for the delay @dragon-slayer875 as I was working on other area. Made changes here PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on
Development

Successfully merging a pull request may close this issue.

2 participants