Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons set to filled by default #663

Open
leecalcote opened this issue Jun 25, 2024 · 5 comments
Open

Icons set to filled by default #663

leecalcote opened this issue Jun 25, 2024 · 5 comments
Assignees
Labels
kind/enhancement Improvement in current feature

Comments

@leecalcote
Copy link
Member

Current Behavior

Related to #654...

Screenshot 2024-06-25 at 4 43 07 PM

Contributor Guide

@heysujal
Copy link

Hi, I would like to take this issue. Can you assign it to me?
I have already cloned the repo, and now I am trying to locate that icon in the code.

@leecalcote
Copy link
Member Author

@heysujal sounds great!

@heysujal
Copy link

heysujal commented Oct 4, 2024

I have done the local setup of project and also made changes in sistent component , but I am not able to find where this is being used in Layer5 site

@heysujal
Copy link

heysujal commented Oct 4, 2024

I have tried to make changes in sistent, then build it. After doing this, I installed it in Layer5 and tried to use it.
For some reason, it is not able to pickup the changes I have made to add the fill property.
These are the changes I have made
EditIcon.tsx
image

404.js in Layer5. (Just for testing out)

image

Output

image

@leecalcote
Copy link
Member Author

@heysujal, apologies, I've not seen you're messages until now. I'm tagging others, who can assist, though. @nebula-aac @sudhanshutech @SAHU-01 @hargunkaur286 @amitamrutiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Development

No branches or pull requests

3 participants