Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pattern to design cmd in scripts #91

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

alphaX86
Copy link
Member

@alphaX86 alphaX86 commented Aug 11, 2024

Description

This PR fixes meshery/meshery#10592

Notes for Reviewers
DON'T MERGE UNLESS meshery/meshery#11051 is merged!
Update: PR is merged. Good to go

Signed commits

  • Yes, I signed my commits.

@gyohuangxin
Copy link
Member

Is it ready for review?

@alphaX86
Copy link
Member Author

Ready. But requires that PR 10592 in Meshery to be reviewed and merged. Only then I'll make this PR as active

@gyohuangxin
Copy link
Member

@alphaX86 Understand. Thank you for your explanation.

@alphaX86 alphaX86 marked this pull request as ready for review October 5, 2024 16:03
Copy link
Contributor

@lekaf974 lekaf974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gyohuangxin gyohuangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alphaX86
Copy link
Member Author

Thanks @gyohuangxin @lekaf974

@alphaX86 alphaX86 merged commit 4148317 into layer5io:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] Rename pattern to design command
3 participants