-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: convert all png to webP #5866
Conversation
This commit do below things: - Convert all png to webP - resolve path for converted png Signed-off-by: Mandeep56Singh <[email protected]>
🚀 Preview for commit 2dca178 at: https://66db4498d116e51aec1fefc4--layer5.netlify.app |
@Mandeep56Singh, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link. |
@Mandeep56Singh, I'm adding this as an agenda item to the meeting minutes. Please join the evening call. |
@Ashparshp is this pull request valid to get merged ? should go with resolving the conflict and updating the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely removed and not added?
Thanks for working on this, @Mandeep56Singh 👍 |
There are some merge conflicts to update. |
@Mandeep56Singh, |
@Mandeep56Singh merge conflicts |
🚀 Preview for commit d0ab98b at: https://66e916e793143aa0ca7dd280--layer5.netlify.app |
thanks guys, for your feedbacks.
if this branch has no breaking changes, I will be happy to convert these to webP. |
I think we're doing good here so far. Let's do a few spot checks to confirm. Here's one to reflect on: In Context (bottom of page) - https://layer5.io/blog/community/on-the-importance-of-github-stars |
@Mandeep56Singh, I have reviewed this several times, and it’s really confusing to review more than 800 file changes. I'm afraid I might miss something. Could we break the PR into parts, such as by page or by grouping selected items into a subtask format? This way, we can approach it more efficiently and merge it faster. I really appreciate the great work you've done! |
@leecalcote it's quite weird its perfectly working fine in netlify build Am I missing something ? |
@Ashparshp thanks. |
@Mandeep56Singh, are you a college student? If yes, please apply for the GitHub Student Developer Pack. It will help you run machines smoothly without limits issues. If not, no worries—I will review all these. |
I think this would be a better approach since it will be easier for review and also reduce risk of issue |
@Ashparshp Ok, then please divide this into small task, and It would be way good if you also tell me the required image dimension for that task. |
Please create PRs in smaller parts, with no more than 20-25 image changes at once. You can start with any of the tasks and we can merge them step by step. |
@Mandeep56Singh i still not heard from you? |
@Mandeep56Singh i saw you have another pr which you are doing in chunks so seems we can close this pr and you carry forward from there. |
Description
This commit do below things:
This PR fixes #5854
Notes for Reviewers
The impact of commit can mainly be seen in through this video
before: the content block due to having 3mb image to load
Layer5.at.KubeCon.EU.2024.-.Google.Chrome.2024-09-06.00-56-23.mp4
after: the image reduced to less than 100kb while maintaining good quality
Blog.-.Google.Chrome.2024-09-06.00-55-57.mp4
nearly 25% size reduction in images from 380 to 288mb
this calculation includes gif,webp,png,jpg,jpeg format
I think the size of images can further reduced if dimension of imags are altered, the image above displayed video has unusaully high resolution 12k * 16k and size of 3mb.
I only altered the dimension of this image to 1440 * 1920 size, resulting in 80kb size while having same quality.
rest of images are just optimized webp
Signed commits