-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Mobile Nav improvement #5781
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit 118c890 at: https://66af314b7275d763e197843b--layer5.netlify.app |
@upsaurav12, can the subitem be enhanced a bit? Maybe background so we can distinguish it properly? |
@upsaurav12 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. Let's have some feedback about it!! |
@Ashparshp Yes i am working on it. I am planning to add background property like |
Signed-off-by: upsaurav12 . <[email protected]>
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit 83dfca3 at: https://66b60f7e46bbbc68f37c7e59--layer5.netlify.app |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit 278d077 at: https://66b624992d2931773ee40f3b--layer5.netlify.app |
@vishalvivekm @Ashparshp i have removed |
Thank you, @upsaurav12. Feel free to discuss and ask anything if needed. Please provide an update as we discussed in the last call about the color. |
@Ashparshp will do |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit 02c9461 at: https://66c0650d9a4e0d4be1aa67c5--layer5.netlify.app |
Hi @Ashparshp @Muhammed-Moinuddin I have done work of most of the feedback but still confused about the background color of |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit deaf3ce at: https://66c311a4d0dc708e64d12b92--layer5.netlify.app |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit cabf6cb at: https://66c31f0fb5731ca519cdbfbf--layer5.netlify.app |
Great work @upsaurav12 ! |
@Muhammed-Moinuddin Thank for suggestion will work on that and push the changes |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit afee72d at: https://66c4d11a3a2f752159df2ced--layer5.netlify.app |
@Muhammed-Moinuddin can you check my newest commit. I have made changes for background color |
Maybe you missed my point, you have not picked the right colors that I recommended. Here you can find them: https://layer5.io/projects/sistent/identity/color/code. Accent-grey code-10 for dark and Accent-grey code-90 for light mode. |
Sorry for my mistake , i was not able to find the |
@Muhammed-Moinuddin it is now looking like this should i commit the changes cinnamon-2024-08-26T1549320530.mp4 |
Sorry @amitamrutiya @Muhammed-Moinuddin Video was not uploaded properly . |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit eb79465 at: https://66cc5a8be850fcd1f74464fd--layer5.netlify.app |
@upsaurav12, What's the update? |
@Ashparshp i have added background color for both dark and light mode as suggested by @Muhammed-Moinuddin |
@upsaurav12, thank you.. Let's discuss this in our upcoming website meeting this Monday, if you're available. Could you please add this to the meeting minutes? |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit 833f546 at: https://66debe47b00b1b02a6d3207a--layer5.netlify.app |
Hi @Ashparshp Sir , I was not active for couple of weeks . So was not able to work for this PR. Now i am working for this issue. |
@upsaurav12, no problem at all! Thanks for the update. Feel free to take your time, and let me know if you need any help as you work on the issue. |
Last time when i attended the meeting. Only sub-items color thing was remaining and color on hovering were left. |
Hi @Muhammed-Moinuddin, |
@upsaurav12 lets hold this for now until we have a good ux'er to give feedback for this . Do you got other issues to work? Lets get you assigned on other important items. |
Thanks @sudhanshutech , |
Description
This PR fixes #5713
Notes for Reviewers
I have added
+
sign for toggle to show and hidesub-items
. I feel this navbar need more improvement in styling alsoAnd it is looking like this
cinnamon-2024-08-04T1256150530.mp4
Signed commits