Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in main.go #288

Open
ShivangShandilya opened this issue Apr 11, 2023 · 3 comments · May be fixed by #289
Open

Changes in main.go #288

ShivangShandilya opened this issue Apr 11, 2023 · 3 comments · May be fixed by #289
Labels
kind/enhancement Improvement in current feature

Comments

@ShivangShandilya
Copy link

ShivangShandilya commented Apr 11, 2023 •
edited
Loading

Current Behavior

Currently in the go code of nighthawks main.go we are using log.Fatal() but log.Fatal() terminates the program completely after encountering an error

Desired Behavior

Here in the go program I think we can handle errors more efficiently using log.Error() instead of log.Fatal(). As log.Fatal() terminates the program completely but log.Error() logs the error msg but allows the program to continue execution. This way, even if one error occurs, the program can continue to process the rest of the results, and the error messages will help in troubleshooting.

Resources
image

Alternatives / Additional Context

Contributor Resources
@ShivangShandilya ShivangShandilya added the kind/enhancement Improvement in current feature label Apr 11, 2023
@welcome
Copy link

welcome bot commented Apr 11, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@ShivangShandilya ShivangShandilya linked a pull request Apr 11, 2023 that will close this issue
Open
1 task
@AryanSharma9917
Copy link
Contributor

HI @ShivangShandilya are you working on this issue?

@ShivangShandilya
Copy link
Author

ShivangShandilya commented Jun 19, 2023 •
edited
Loading

hey @AryanSharma9917 as you can see I have already opened up a PR which might close this issue when merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvement in current feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update main.go ShivangShandilya/getnighthawk
2 participants
@AryanSharma9917 @ShivangShandilya