Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract shutdown behaviour #43

Open
lawrencejones opened this issue May 23, 2020 · 1 comment
Open

Extract shutdown behaviour #43

lawrencejones opened this issue May 23, 2020 · 1 comment
Labels
code-improvement Improvement to the internal code, not a feature

Comments

@lawrencejones
Copy link
Owner

lawrencejones commented May 23, 2020 •
edited
Loading

The whole 'request shutdown, but also wait for context expiry, and the Shutdown(ctx) method` is repeated across all the components. It feels like something which should be composed with a concurrent task, rather than reimplemented.

Especially as it's not obvious how it works: shutdown channel, wait on shutdown, ensure we close done, make done a buffered by one channel.
@lawrencejones
Copy link
Owner Author

Another example in #44

@lawrencejones lawrencejones added the code-improvement Improvement to the internal code, not a feature label Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-improvement Improvement to the internal code, not a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrencejones