Segmentation fault when running DELETE statement

[mrship]

Firstly, thanks for all your work on this FDW. We've just started exploring this and it is very promising for our needs. However, we've found a bug!

When executing a DELETE statement against a foreign table we're experiencing a segmentation fault on postgres. The statement is DELETE FROM table where (1=0) which runs fine on Oracle (and deletes nothing, as expected).

We can try avoiding this style of DELETE but I would not have expected it to cause a segmentation fault?

Here's the log from the server.

CET [13416] LOG:  server process (PID 14982) was terminated by signal 11: Segmentation fault
CET [13416] DETAIL:  Failed process was running: DELETE FROM "salesforce_impersonations" WHERE (1 = 0)
CET [13416] LOG:  terminating any other active server processes
WARNING CET [14974] WARNING:  terminating connection because of crash of another server process
CET [14974] DETAIL:  The postmaster has commanded this server process to roll back the current transaction and exit, because another server process exited abnormally and possibly corrupted shared memory.
CET [14974] HINT:  In a moment you should be able to reconnect to the database and repeat your command.
CET [13416] LOG:  all server processes terminated; reinitializing 

admin@(none):admin> SELECT oracle_diag('admin');
+--------------------------------------------------------------------------------------------+
| oracle_diag                                                                                |
|--------------------------------------------------------------------------------------------|
| oracle_fdw 2.1.1devel, PostgreSQL 11.1, Oracle client 12.1.0.2.0, Oracle server 12.1.0.2.0 |
+--------------------------------------------------------------------------------------------+
SELECT 1

[laurenz]

Embarrassing. Thanks for the report!

Could you check if that commit fixes the problem for you?

[mrship]

That worked!

admin> DELETE FROM salesforce_impersonations WHERE (1 = 0);
DELETE 0
Time: 0.127s

thanks for the quick turnaround.