Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector Support #497

Closed
lolJS opened this issue Jul 1, 2024 · 4 comments
Closed

Inspector Support #497

lolJS opened this issue Jul 1, 2024 · 4 comments
Labels
feature Label for feature requests package: sdk/react-native Issues that affect the react native SDK. Stale

Comments

@lolJS
Copy link

lolJS commented Jul 1, 2024

Is your feature request related to a problem? Please describe.
I would love to see the react-native SDK support inspectors or provide a similar event:

 inspectors: [
    {
      type: "flag-used",
      name: "dd-inspector",
      method: (key: string, detail: LDClient.LDEvaluationDetail) => {
        datadogRum.addFeatureFlagEvaluation(key, detail.value);
      },
    },
  ],

Describe the solution you'd like
Inspector support: https://docs.launchdarkly.com/sdk/features/inspectors#javascript

Describe alternatives you've considered
I explored using the SDK's existing client.on("change") event.

@lolJS lolJS added feature Label for feature requests package: sdk/react-native Issues that affect the react native SDK. labels Jul 1, 2024
@sergioalmela
Copy link

Same for node

@kinyoklion
Copy link
Member

Hello @sergioalmela,

For react native we will eventually be adding the hooks and inspector interface.

For the node server SDK you can use hooks. They are our long-term replacement for inspectors and support the use case from this ticket.

https://github.com/launchdarkly/open-sdk-specs/tree/main/specs/HOOK-hooks

In the afterEvaluation method you would call the datadog rum method.

Copy link
Contributor

This issue is stale because it has been open for 90 days without activity. Remove the stale label or comment, or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 15, 2024
@kinyoklion
Copy link
Member

@lolJS

The 10.9.0 version of the react-native SDK now includes both hooks and inspectors. I would recommend hooks as the plan is eventually to phase out inspectors.

Thank you,
Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Label for feature requests package: sdk/react-native Issues that affect the react native SDK. Stale
Projects
None yet
Development

No branches or pull requests

3 participants