You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice if you could add some more information on what sending events to Laudspeaker means, e.g. how those events are going to be used. This would also push potential users to use Laudspeaker. I would also add information on how to retrieve your API Key.
Is this default URL valid: http://13.40.100.193:3000/events/posthoglaud
If not, this could be confusing, I tried to run the App with this first. I would remove the default and add a better explanation to which URL to use.
Also, just a nit, but there's some empty else statements here:
Hey @kappa90 we just completed the changes requested above please let us know if its good to go!
One point I'm adding a full fledged loom later today to show how everything fits together. But you can see the data from posthog in the people tab (you may not want to use a massive posthog project to sync but it is working with 10k users so far)
Hi, a few fixes I'd require before approving this plugin:
I could run the plugin successfully, but I can't see the data anywhere in Laudspeaker.
phEmail
,phPhoneNumber
andphCustom
inplugin.json
are not used, please remove them: https://github.com/laudspeaker/laudspeaker-posthog-plugin/blob/master/plugin.jsonIt would be nice if you could add some more information on what sending events to Laudspeaker means, e.g. how those events are going to be used. This would also push potential users to use Laudspeaker. I would also add information on how to retrieve your API Key.
Is this default URL valid: http://13.40.100.193:3000/events/posthoglaud
If not, this could be confusing, I tried to run the App with this first. I would remove the default and add a better explanation to which URL to use.
Also, just a nit, but there's some empty
else
statements here:laudspeaker-posthog-plugin/index.js
Line 281 in 16ccd8b
laudspeaker-posthog-plugin/index.js
Line 292 in 16ccd8b
The text was updated successfully, but these errors were encountered: