Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to hyperref-doc.tex chapters 4 and 6 #256

Open
ggustaf opened this issue Sep 1, 2022 · 1 comment
Open

Edits to hyperref-doc.tex chapters 4 and 6 #256

ggustaf opened this issue Sep 1, 2022 · 1 comment

Comments

@ggustaf
Copy link

ggustaf commented Sep 1, 2022

The comments were deleted because of errors. Some of the errors propagated from StackExchange posts. Other errors arose by rewording the existing text in hyperref-doc.pdf. The task is beyond my expertise, so I retract previous proposed edits. In my opinion, hyperref manual edits should be done by someone who knows the macros intimately.

@u-fischer
Copy link
Member

sorry but there are various errors and imprecisions in the text. E.g.

  • Hyperref implements a PDF destination as \pdfdest: \pdfdest is not implemented by hyperref, that is a primitive command provided by pdflatex.

  • targets are automatically created for \label: \label doesn't create a target, it uses it.

  • A target name created by \refstepcounter can be invalid: the name is not invalid, it is only not usable as it can't be computed easily from the bib-key, a name based on the bib-key is better.

  • this example is wrong:

\cleardoublepage
\chapter*{Appendix B}
\phantomsection
\addcontentsline{toc}{chapter}{{Appendix B}

Unless the class interferes \chapter* creates a target (not with \refstepcounter but through a different patch) and the \phantomsection is unneeded. Similar for the bibliography example: if one assume that the heading is set with \chapter* no \phantomsection is needed.

I will look if I can add a few examples how and when to create manually targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants